fix(footer): use simple-icons SVG for X logo to fix compression - #233
fix(footer): use simple-icons SVG for X logo to fix compression#233GautierPicon wants to merge 1 commit into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
@GautierPicon is attempting to deploy a commit to the Jamie's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Codex review: needs maintainer review before merge. Reviewed August 15, 2026, 6:53 PM ET / 22:53 UTC. ClawSweeper reviewWhat this changesThe PR replaces the footer’s Unicode X glyph with the Simple Icons X SVG, alongside formatter-driven rewrites of the Astro template. Merge readinessKeep this PR open for maintainer review: current main still uses the compressed Unicode X glyph, and the proposed SVG replacement is correct and visibly evidenced. Priority: P3 Review scores
Verification
How this fits togetherThe shared Astro footer provides the public site’s navigation and social links. Its social-link data selects an SVG path or a text glyph, then renders the selected icon in every page using the footer. flowchart LR
A[Public site page] --> B[Shared footer]
B --> C[Social-link data]
C --> D{Icon representation}
D -->|SVG path| E[Inline SVG icon]
D -->|Text glyph| F[Font-rendered symbol]
E --> G[Footer navigation]
F --> G
Decision needed
Why: Both paths can be valid, but accepting non-functional churn in a shared template is a maintainer review-scope choice. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Copy recommended automerge instructionTechnical reviewBest possible solution: Land the SVG replacement after a quick shared-footer review, preferably with unrelated formatting omitted from the patch. Do we have a high-confidence way to reproduce the issue? Yes: current main selects a font-rendered Unicode glyph for X, and the supplied before/after screenshots directly show the proposed SVG correction. Is this the best way to solve the issue? Yes: using the repository’s existing Simple Icons X path is the narrowest maintainable fix; the unrelated formatter rewrite should be separated where practical. AGENTS.md: found, but no applicable review policy affected this item. Codex review notes: model internal, reasoning high; reviewed against 834f7ea7b1c8. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (9 earlier review cycles; latest 8 shown)
|
Replace the Unicode glyph 𝕏 used for the X social icon in the footer with the official simple-icons SVG (siX). The glyph rendered compressed in its 18px box; the SVG matches the other footer icons and renders correctly.
Ref: src/components/SiteFooter.astro
Note: The formatting changes in SiteFooter.astro (single to double quotes, line wrapping) come from the prettier auto-formatter, not from manual edits. The only functional change is replacing the Unicode glyph 𝕏 with the simple-icons SVG (siX).