Skip to content

chore: increse db size#996

Merged
suvanbanerjee merged 4 commits into
mainfrom
chore/update-dev-db
Jun 10, 2026
Merged

chore: increse db size#996
suvanbanerjee merged 4 commits into
mainfrom
chore/update-dev-db

Conversation

@suvanbanerjee

@suvanbanerjee suvanbanerjee commented Jun 10, 2026

Copy link
Copy Markdown
Member

Pull Request

Description

Increase DB size

Screenshot From 2026-06-10 11-59-44

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@suvanbanerjee suvanbanerjee requested a review from devsjc June 10, 2026 07:32

@devsjc devsjc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if instead we should make it allocated_storage = 200 and max_allocated_storage = 1024 - or is that not allowed?

@suvanbanerjee

suvanbanerjee commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

On AWS I have made it 512GiB so i made the same here what do you think should be appropriate size for the allocated_storage ?

It is allowed to do so we just have to make sure max_allocated_storage is 10% more than allocated_storage

Currently the free space is 329.7GiB on RDS and allocated is 512GiB that leaves us with 182GiB used or 18GiB Free space (if we make it 200GiB)

@devsjc

devsjc commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

I guess I just didn't want us to be paying for 512 in prod when we're only using 75! You only pay for what you use under max_ but you pay flat for allocated_. But I'm not sure whether you can move allocated back down again once it's gone up!

Maybe it's best to make it a variable and then we can set it on each instance seperately? And have it default to what I said above?

@suvanbanerjee

suvanbanerjee commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

I just looked in AWS and it's not possible to reduce the storage back to 200
image

@suvanbanerjee suvanbanerjee requested a review from devsjc June 10, 2026 10:22

@devsjc devsjc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Suvan, thanks for the restructuring here! One more change!

Comment thread terraform/modules/storage/postgres/variables.tf Outdated
@suvanbanerjee suvanbanerjee requested a review from devsjc June 10, 2026 10:27
@suvanbanerjee suvanbanerjee merged commit 6bbbb02 into main Jun 10, 2026
5 checks passed
@suvanbanerjee suvanbanerjee deleted the chore/update-dev-db branch June 10, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants