Add projection coordinates #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsjc
approved these changes
Dec 18, 2025
Contributor
devsjc
left a comment
devsjc
left a comment
There was a problem hiding this comment.
Nice, appreciate the internal function name consistency!
devsjc
force-pushed
the
projection_location_metadata
branch
from
94bb89f to
8a48c96
Compare
devsjc
added a commit
that referenced
this pull request
Dec 22, 2025
* feat(storage): Add new data vars and metadata * chore(repo): Refactor and simplify service * feat(service): Enable icechunk * feat(process): Enable sharding * fix(repo): Correctly use importlib * feat(download): Save raw files in subfolders * chore(download): Address PR comments * chore(process): Specify earth disk Co-authored-by: James Fulton <[email protected]> * feat(write): Properly check for existing times * fix(process): Efficient satpy usage (#67) * Refactor satpy usage for speed * lint * Add attrs * Speed up nan-frac calculation (#68) * Speed up nan-frac calculation * linting * enforce type * chore(process): Speed up coordinate reordering (#69) speed up spatial coord sorting * chore(pyproject): Satpy pin * chore(process): More NaN leeway * chore(consume): Don't break on skipped low-quality files * chore(process): Refactor geos bound calculation (#70) * Use area attr to calculate geos bounds * linting * igore type * chore(repo): Linting --------- Co-authored-by: devsjc <[email protected]> * fix(consume): Don't break on validation error * fix(process): Allow ValidationError through * Add projection coordinates (#72) * fix(process): Save instrument as fixed length string * chore(process): Increase NaN allowable threshold * chore(process): Allow 20% NaNs on earth disk --------- Co-authored-by: James Fulton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the projection coordinates to the dataset. This should solve #28
__map_scene_to_dataset()for the values we extract directly from the attrs but not for the values we extract through functions since the functions have return type hints anywaycal_slopeandcal_offset)