Feat/dataplatform save adjuster#112
Open
PavanRaghavendraKulkarni wants to merge 26 commits intomainfrom
Open
Conversation
…in save_forecast function
…py, save.py, and related tests
…anced functionality in save.py and tests
…e clarity and maintainability
…ved mocking in tests
…ward compatibility; remove outdated test files
…mprove forecast writing logic
…o enable ME value retrieval
…_forecast functionality
… and commit changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR implements and refactors the logic for saving forecasts (including adjusted forecasts) to the Data Platform.
The save_forecast functionality has been moved into a dedicated save.py module to improve separation of concerns and maintainability. The PR ensures that adjusted forecasts are correctly constructed and persisted, with improved error handling and cleaner parameter handling.
Key changes:
Refactored forecast saving logic into a separate module
Implemented saving of adjusted forecasts to the Data Platform
Improved error handling in save flow
Cleaned up imports and normalized parameters
Added unit and integration tests
Updated relevant dependencies
Fixes #163
How Has This Been Tested?
Added unit tests for the save logic
Added integration tests covering adjusted forecast creation and save flow
Ran the application locally to verify forecasts are generated and successfully sent to the Data Platform
Performed a sanity check to ensure adjusted forecast values are correctly passed through the pipeline
Yes
Checklist: