Skip to content

Feat/dataplatform save adjuster#112

Open
PavanRaghavendraKulkarni wants to merge 26 commits intomainfrom
feat/dataplatform-save-adjuster
Open

Feat/dataplatform save adjuster#112
PavanRaghavendraKulkarni wants to merge 26 commits intomainfrom
feat/dataplatform-save-adjuster

Conversation

@PavanRaghavendraKulkarni
Copy link
Contributor

@PavanRaghavendraKulkarni PavanRaghavendraKulkarni commented Feb 18, 2026

Pull Request

Description

This PR implements and refactors the logic for saving forecasts (including adjusted forecasts) to the Data Platform.

The save_forecast functionality has been moved into a dedicated save.py module to improve separation of concerns and maintainability. The PR ensures that adjusted forecasts are correctly constructed and persisted, with improved error handling and cleaner parameter handling.

Key changes:

  • Refactored forecast saving logic into a separate module

  • Implemented saving of adjusted forecasts to the Data Platform

  • Improved error handling in save flow

  • Cleaned up imports and normalized parameters

  • Added unit and integration tests

  • Updated relevant dependencies

Fixes #163

How Has This Been Tested?

  • Added unit tests for the save logic

  • Added integration tests covering adjusted forecast creation and save flow

  • Ran the application locally to verify forecasts are generated and successfully sent to the Data Platform

  • Performed a sanity check to ensure adjusted forecast values are correctly passed through the pipeline

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

…ward compatibility; remove outdated test files
@PavanRaghavendraKulkarni PavanRaghavendraKulkarni marked this pull request as ready for review February 18, 2026 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant