-
-
Notifications
You must be signed in to change notification settings - Fork 25
Add fetch_be_forecast function to get Belgium solar forecast (regiona… #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| return pd.DataFrame() | ||
|
|
||
|
|
||
| def fetch_be_forecast() -> pd.DataFrame: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you move this into a seperate file please, in the data dir
| return df_forecast | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be able to write a test for this? perhaps an integration test?
|
Also thank you so much for doing all this. Does this code pull the regional data too? |
Hi @peterdudfield, thank you very much for the review — and sorry for the delayed response. I’ve addressed your feedback in a new pull request (#134):
Please let me know if you’d like anything adjusted or simplified further for the new PR — happy to iterate on this based on your feedback. |
|
Thanks @Reem-Albadwy , shall we close this one? |
yes, it is better to close it |
…l + national)
Pull Request
Description
This PR introduces a new function
fetch_be_forecastto retrieve Belgium solar forecast data from Elia open data. The function collects both regional and national forecasts, standardizes column names, and ensures the datetime column is properly converted to UTC.Related issue: Fixes #127
How Has This Been Tested?
target_datetime_utc,Region,solar_generation_kw.Datetimecolumn to datetime format in UTC successfully.Checklist