Skip to content

Blend app: implement feature flag to read from Data Platform#77

Merged
katyalmohit merged 15 commits intomainfrom
feature-flag-dp
Mar 5, 2026
Merged

Blend app: implement feature flag to read from Data Platform#77
katyalmohit merged 15 commits intomainfrom
feature-flag-dp

Conversation

@katyalmohit
Copy link
Contributor

@katyalmohit katyalmohit commented Feb 23, 2026

Pull Request

Description

  • This PR adds an option to read forecasts from the Data Platform instead of the database.
  • By default, the blend service still reads forecasts from nowcasting_datamodel.
  • If we set the environment variable: READ_FROM_DATA_PLATFORM=true, the service will read forecast values from the Data Platform instead.

Fixes: https://github.com/openclimatefix/client-private/issues/158

How Has This Been Tested?

  • Added integration tests
  • Tested with the development database and data-platform

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link

@PavanRaghavendraKulkarni PavanRaghavendraKulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peterdudfield
Copy link
Contributor

Actually could you run this with data-platform 0.21.2, you'll need to update th docker image too

@peterdudfield
Copy link
Contributor

Also did you run it with the dev env and check that the dashboard is shows the forecast properly. Sometimes the probabilistic values were missing

@katyalmohit
Copy link
Contributor Author

Also did you run it with the dev env and check that the dashboard is shows the forecast properly. Sometimes the probabilistic values were missing

Yeah, sometimes it does that. I will investigate it further.

Copy link
Contributor

@peterdudfield peterdudfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Investigate why probabilistic values are none sometimes

@peterdudfield
Copy link
Contributor

I ran this locally and it worked. I think the nonn probablistic values are from old runs, and should be delete from the database. I reckon we go ahead and merge this

@katyalmohit katyalmohit merged commit cf3de32 into main Mar 5, 2026
4 checks passed
@katyalmohit katyalmohit deleted the feature-flag-dp branch March 5, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants