Conversation
Took 46 minutes
Took 23 seconds
Took 48 seconds
Took 27 seconds
nowcasting_api/cache.py
Outdated
| ``` | ||
| """ | ||
| cache = TTLCache(maxsize=1024, ttl=cache_time_seconds) | ||
| cache = TTLCache(maxsize=128, ttl=cache_time_seconds) |
Collaborator
There was a problem hiding this comment.
bump up to 512, becasue there are 318 gsps
peterdudfield
approved these changes
Mar 3, 2026
Collaborator
peterdudfield
left a comment
peterdudfield
left a comment
There was a problem hiding this comment.
Incerase cache size, see comments
Took 7 minutes
Took 1 minute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
remove save_api_call_to_db from status calls
make tracemalloc optional/on-demand
try/finally to avoid reqs following exception waiting 30s
reduce cache size
remove save_api_requests & session obj
Fixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: