Skip to content

Hash app lock secrets#149

Open
zerox80 wants to merge 1 commit intoopencloud-eu:mainfrom
zerox80:security/hash-app-lock-secrets
Open

Hash app lock secrets#149
zerox80 wants to merge 1 commit intoopencloud-eu:mainfrom
zerox80:security/hash-app-lock-secrets

Conversation

@zerox80
Copy link
Copy Markdown
Contributor

@zerox80 zerox80 commented May 8, 2026

What changed

  • Store PIN and pattern lock values as salted PBKDF2 hashes instead of plain text.
  • Migrate old plain text values after a successful unlock.
  • Stop logging the actual pattern while the user draws it.

Why

The app lock should not leave the PIN or pattern readable in preferences or logs. Existing users can still unlock once with the old value, then it gets upgraded.

Checks

  • git diff --check
  • Targeted rg scans for plain text app-lock storage and pattern value logs
  • Gradle tests not run locally because JAVA_HOME is not set and java is not on PATH

@zerox80 zerox80 marked this pull request as ready for review May 8, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant