-
Notifications
You must be signed in to change notification settings - Fork 27
Update product name #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
cced12c
f0f24ea
b842d2c
870674d
4a142b3
c877c3b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -85,8 +85,7 @@ void AboutDialog::setupUpdaterWidget() | |
| } | ||
| // we want to attach the known english identifiers which are also used within the configuration file as user data inside the data model | ||
| // that way, when we intend to reset to the original selection when the dialog, we can look up the config file's stored value in the data model | ||
| ui->updateChannel->addItem(QStringLiteral("ownCloud 10 LTS"), QStringLiteral("stable")); | ||
| ui->updateChannel->addItem(QStringLiteral("ownCloud Infinite Scale stable"), QStringLiteral("ocis")); | ||
| ui->updateChannel->addItem(QStringLiteral("stable"), QStringLiteral("stable")); | ||
| if (!Resources::isVanillaTheme()) { | ||
| ui->updateChannel->addItem(tr("beta"), QStringLiteral("beta")); | ||
| } | ||
|
|
@@ -158,8 +157,7 @@ void AboutDialog::slotUpdateChannelChanged([[maybe_unused]] int index) | |
|
|
||
| auto msgBox = new QMessageBox(QMessageBox::Warning, tr("Change update channel?"), | ||
| tr("<html>The update channel determines which client updates will be offered for installation.<ul>" | ||
| "<li>\"ownCloud 10 LTS\" contains only upgrades that are considered reliable</li>" | ||
| "<li>\"ownCloud Infinite Scale stable\" contains only upgrades that are considered reliable but <b>removes support for \"ownCloud 10\"</b></li>" | ||
| "<li>\"stable\" contains only upgrades that are considered reliable</li>" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ... as we might get another product anytime the next decade? |
||
| "%1" | ||
| "</ul>" | ||
| "<br>⚠️Downgrades are not supported. If you switch to a stable channel this change will only be applied with the next major release.</html>") | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,7 +36,7 @@ void OCC::QmlUtils::OCQuickWidget::setOCContext(const QUrl &src, QWidget *parent | |
| rootContext()->setContextProperty(QStringLiteral("ocQuickWidget"), this); | ||
| rootContext()->setContextProperty(QStringLiteral("ocContext"), ocContext); | ||
| engine()->setObjectOwnership(ocContext, ownership); | ||
| engine()->addImageProvider(QStringLiteral("ownCloud"), new OCC::Resources::CoreImageProvider()); | ||
| engine()->addImageProvider(QStringLiteral("OpenCloud"), new OCC::Resources::CoreImageProvider()); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure to spread |
||
| setResizeMode(QQuickWidget::SizeRootObjectToView); | ||
|
|
||
| // Ensure the parent widget used OC_DECLARE_WIDGET_FOCUS | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,8 +53,8 @@ QString UpdateInfo::downloadUrl() const | |
|
|
||
| UpdateInfo UpdateInfo::parseElement(const QDomElement &element, bool *ok) | ||
| { | ||
| if (element.tagName() != QLatin1String("owncloudclient")) { | ||
| qCCritical(lcUpdater) << "Expected 'owncloudclient', got '" << element.tagName() << "'."; | ||
| if (element.tagName() != QLatin1String("OpenCloud")) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| qCCritical(lcUpdater) << "Expected 'OpenCloud', got '" << element.tagName() << "'."; | ||
| if (ok) | ||
| *ok = false; | ||
| return UpdateInfo(); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous name is more specific, and maybe the new one should also be "OpenCloud" and "OpenCloud" ... or so ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can decide on this once we again have auto updates 🙈