test: selective sync for selected folders #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anon-pradip
force-pushed
the
test/selective-sync-only-some-folders
branch
4 times, most recently
from
dd62929 to
8e11249
Compare
21 tasks
anon-pradip
force-pushed
the
test/selective-sync-only-some-folders
branch
2 times, most recently
from
281c843 to
6ccbd88
Compare
anon-pradip
force-pushed
the
test/selective-sync-only-some-folders
branch
from
6ccbd88 to
a6be2b3
Compare
individual-it
requested changes
Sep 26, 2025
| ) | ||
| else: | ||
| squish.doubleClick(squish.waitForObject(selector)) | ||
| SyncConnectionWizard.select_or_unselect_folders_to_sync(folders, select=True) |
There was a problem hiding this comment.
why not calling SyncConnectionWizard.select_or_unselect_folders_to_sync directly where now select_folders_to_sync is used?
There was a problem hiding this comment.
Because the step definition mentions selection explicitly. So including select_folders_to_sync makes it more readable and for Encapsulation also.
| ).enabled | ||
|
|
||
| @staticmethod | ||
| def select_or_unselect_folders_to_sync(folders, select=True): |
There was a problem hiding this comment.
the naming is confusing as this is not about select and unselect but about two different wizards that have slightly different locators
There was a problem hiding this comment.
I introduced in_choose_what_to_sync_dialog flag to be more specific related to specific widget
anon-pradip
force-pushed
the
test/selective-sync-only-some-folders
branch
6 times, most recently
from
414702d to
0ee2951
Compare
individual-it
approved these changes
Nov 5, 2025
saw-jan
reviewed
Nov 5, 2025
anon-pradip
force-pushed
the
test/selective-sync-only-some-folders
branch
from
0ee2951 to
11041af
Compare
saw-jan
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test for selective sub-folder exclusion scenario.
Note: There are two windows where selection/deselection of resources can happen:
Add spacewindow:Choose what to syncwindowChanges:
test/gui/shared/scripts/names.py: Added object definitions for UI elements in the "Choose what to sync" dialog (QLabel, QTreeWidget, QModelIndex, QPushButton) to support folder deselection functionality.
test/gui/shared/scripts/pageObjects/SyncConnection.py: Removed unused
unselect_folder_in_selective_syncmethod.test/gui/shared/scripts/pageObjects/SyncConnectionWizard.py: Renamed
SYNC_DIALOG_FOLDER_TREEtoADD_SPACE_FOLDER_TREEfor clarity in distinguishing add-space vs. choose-what-to-sync dialogs; addedCHOOSE_WHAT_TO_SYNC_FOLDER_TREElocator for "Choose what to sync" dialog support; removed unusedselect_folders_to_syncmethod; addedselect_or_unselect_folders_to_syncfor unified select/unselect logic with dialog parameter; addedconfirm_choose_what_to_sync_selectionto click OK in "Choose what to sync" dialog; added_handle_folder_selectionhelper to perform action and confirm based on dialog type; refactoredunselect_folders_to_syncandselect_folders_to_syncto use helper with dialog flag; addedget_folder_tree_locatorto return appropriate locator based on dialog context.test/gui/shared/steps/file_context.py: Consolidated separate "should exist" and "should not exist" steps into a single regex-based step for files/folders, reducing duplication
test/gui/tst_syncing/test.feature: Added scenario "Unselected subfolders are excluded from local sync"
Part of: #370
Blockage: Could not test on windows due to #435