Pause sync before we terminate #642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
force-pushed
the
work/sched2
branch
from
d7a1478 to
203e658
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the slotEnableCurrentFolder function to improve code clarity and fix a logic bug. The changes make the variable currentlyPaused const, improve comment grammar, and reorder operations to ensure proper state management.
Key Changes:
- Made
currentlyPausedvariableconstand moved initialization to declaration - Reordered operations to set folder state before attempting to terminate sync
- Fixed grammar in comment from "its" to "it's" and corrected "where" to "were"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
That ensures that a folder is not rescheduled Fixes: #632
TheOneRing
force-pushed
the
work/sched2
branch
from
203e658 to
6c10d83
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } else { | ||
| // set paused to prevent reschedule | ||
| folder->setSyncPaused(true); | ||
| // terminate the run if we previously where syncing |
There was a problem hiding this comment.
Corrected spelling of 'where' to 'were'.
Suggested change
| // terminate the run if we previously where syncing | |
| // terminate the run if we previously were syncing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.