Add custom HTTP header support for proxies#6
Open
markrosan8 wants to merge 1 commit intoopencloud-eu:mainfrom
Open
Add custom HTTP header support for proxies#6markrosan8 wants to merge 1 commit intoopencloud-eu:mainfrom
markrosan8 wants to merge 1 commit intoopencloud-eu:mainfrom
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for a user-configurable custom HTTP header that is attached to every outgoing request. The header name and value are read from NSUserDefaults in prepareRequestForScheduling:, the single chokepoint for all HTTP requests in the SDK. Leaving either field empty results in no header being added.
Related Issue
Resolves https://github.com/orgs/opencloud-eu/discussions/2557
Motivation and Context
Users running OpenCloud behind reverse proxies sometimes need a custom HTTP header on all requests for routing or authentication gating. The iOS app currently has no way to attach custom headers, which can prevent the app from working in these deployments.
How Has This Been Tested?
Built and tested on iOS sim. Verified via Traefik access logs that the custom header appears on all outgoing requests. Verified that leaving the fields empty results in no change to existing behavior.
Screenshots (if appropriate):
See companion PR in opencloud-eu/ios.
Types of changes
Checklist: