Skip to content

fix: allow 'make dev-docker' with go.work #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: allow 'make dev-docker' with go.work #1778

wants to merge 1 commit into from
+7 −5

Conversation

@rhafer
Copy link
Contributor

@rhafer rhafer commented Nov 4, 2025 •
edited
Loading

Alternative to: #1527

@rhafer rhafer force-pushed the go-work branch 3 times, most recently from bda963e to 2034d9f Compare November 4, 2025 17:02
@rhafer rhafer changed the title quick test fix: allow 'make dev-docker' with go.work Nov 4, 2025
@rhafer rhafer self-assigned this Nov 4, 2025
@github-project-automation github-project-automation bot moved this to Qualification in OpenCloud Team Board Nov 4, 2025
@rhafer rhafer moved this from Qualification to In Progress in OpenCloud Team Board Nov 4, 2025
@rhafer rhafer marked this pull request as ready for review November 5, 2025 07:18
@rhafer rhafer requested a review from micbar November 5, 2025 07:18
@micbar
Copy link
Contributor

micbar commented Nov 6, 2025

I tried it locally.

 > [linux/arm64 build 4/4] RUN --mount=type=bind,target=/build,rw     --mount=type=cache,target=/go/pkg/mod     --mount=type=cache,target=/root/.cache     GOOS="linux" GOARCH="arm64" ;     make -C opencloud/opencloud release-linux-docker-arm64 ENABLE_VIPS=true DIST=/dist:
0.081 make: Entering directory '/build'
0.081 make: Leaving directory '/build'
0.081 make: *** opencloud/opencloud: No such file or directory.  Stop.

@rhafer
Copy link
Contributor Author

rhafer commented Nov 6, 2025

I tried it locally.

 > [linux/arm64 build 4/4] RUN --mount=type=bind,target=/build,rw     --mount=type=cache,target=/go/pkg/mod     --mount=type=cache,target=/root/.cache     GOOS="linux" GOARCH="arm64" ;     make -C opencloud/opencloud release-linux-docker-arm64 ENABLE_VIPS=true DIST=/dist:
0.081 make: Entering directory '/build'
0.081 make: Leaving directory '/build'
0.081 make: *** opencloud/opencloud: No such file or directory.  Stop.

@micbar How did you run it? Was that a make dev-docker or some manual docker build(x) call?

@rhafer
Copy link
Contributor Author

rhafer commented Nov 6, 2025

@micbar Please try again. The make dev-docker-multiarch step should work now as well.

micbar
micbar approved these changes Nov 7, 2025
View reviewed changes
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@micbar micbar micbar approved these changes

Assignees

@rhafer rhafer

Labels

None yet

Projects

OpenCloud Team Board
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rhafer @micbar