OC-116 migrate ant to maven #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in META-INF, simplify build.xml so that it just calls maven; enhance also clover-base-pom adding default library and plugin versions and updating version to 4.5.0-SNAPSHOT; update version number also in common.xml; update target dependencies in clover-core, clover-runtime and groovy (as clover-buildutil.jar target has been deleted)
…r, instead of the classes folder
…ld plugins, make javadocs quiet and not complaining about missing tags
… a major version, build prefixes etc)
…d.stamp - we can just use the build.stamp; change format of build.date to yyyy-MM-dd; use the same format for maven.build.timestamp; define a set of properties we use in ant in the root pom.xml
…lover-runtime module
… 'src/main/resources', respectively (part 1)
… 'src/main/resources', respectively (part 2)
… 'src/main/resources', respectively (part 3)
…eclipse.ant' (but without renaming java packages)
…clover.eclipse.updatesite' (but without renaming java packages)
…ver.eclipse.testopt' (but without renaming java packages)
…ver.eclipse.feature' (but without renaming java packages)
…nclover.eclipse.ant.feature' (but without renaming java packages)
…over.eclipse.branding' (but without renaming java packages)
…ver.eclipse.runtime' (but without renaming java packages)
….eclipse.core' (but without renaming java packages)
…lipse.*' in a few overlooked files
…1 of 2 moving files
…2 of 2 - renaming packages and references in resource files
… references in test files and resources files
…t use a clover-*.jar pattern in the build_quick.xml in the tutorial to install it
…te iml file, created release script
This reverts commit 29850c3.
This reverts commit d0862c9.
…he same time it can't be put in src/main/resources, otherwise Groovy compiler will try to run the transformation while building the module, leading to errors; therefore using the different location for META-INF/services and the assembly plugin to pack the jar; the IGlobalExtension must be present inside clover.jar, not groovy.jar, so moving it to clover-all module
…over-core module - they are being used only to render HTML reports, not to instrument code, as we use AST transformer for that; similarly, moving Spock-related test interceptors to clover-core - as they are not using during compilation by AST transformer, but during test execution; to sum up, the groovy.jar shall contain code instrumenter only, the main clover.jar shall handle spock tests as well as syntax highlighting for groovy
… probably previously it was a transitive dependency of spock, which is in the 'test' scope now
…s-plugin configuration, which was copying the same files to both classes and test-classes directories
…'s more comfortable to have one directory after unpacking); include third party licenses in the ZIP too (in addition to what we have inside clover.jar); change packaging to pom as we don't want to create a JAR file
…zip is created instead
…ished a milestone version; renamed stableVersionInfo.xml to latestStableVersion.xml (as such name is used on the openclover.org website); filtering values in latestStableVersion.xml
…t to ensure we have all possible classes/resourcs); using assembly plugin to create IDEA plugin jar (the JAR produced by maven-jar-plugin did not have necessary dependencies); copying src/main/resources as META-INF/services were missing in the JAR
…as missing on a classpath
…y is no longer available, downloading JARs directly from packages.atlassian.com instead
…d during test execution; packing idea.jar + others.jar (all third party libs) + devkit.jar plugin, which are used only for compilation
…dea/lib) and two plugins (idea/plugins/properties and idea/plugins/devkit), installing them locally, created clover-idea-all pom declaring all these libraries as dependencies, list of dependencies and their installation can be generated automatically via generate-idea-dependencies.sh and generate-install-file-calls.sh; these changes resolve some of the errors during test execution (mainly problems with loading IntelliJ components); disabling useManifestOnlyJar
…of them rely on data from this project; build the project using openclover's commandline instead of clover-for-ant (to get rid of the dependency on Ant); still using maven-antrun-plugin though; using a short number for cij.idea.expected.version
… not visible" problem when building from IntelliJ
…ing from IntelliJ
…s' due to cglib<->asm version conflict (tests were failing with an error that one class tried to override a final method from another)
|
The build is finally green, all compiled and tested by Maven. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.