Temporarily remove web caching due to diskcache CVE #1470
Merged
Conversation
Member
|
There is a caching layer directly for HTTPX that uses sqlite underneath. Perhaps that could be used and would remove some of the logic here. I've been wondering whether code for interacting with repositories should be moved into a separate package... |
Member
Author
|
Might work but it does not provide a max cache size and it would have to be implemented at another place in the codebase (the actual download). Though I would prefer the cache to be a directory of SBML files, not some binary format hidden away in a DB. |
Member
Author
|
I agree with everything else. Separate package for web loading and caching would be great. Also because the testing strategy probably should be different. Outages in Biomodels currently break our CI for instance. |
108ac03 to
59a993a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
diskcachepackage is currently flagged with a CVE. Unfortunately the project seems to be abandoned and no fix has been merged for 1+ months. This temporarily removes the dependency of diskcache by disabling the caching. I am happy to reactivate if the CVE gets fixed or an alternative pops up. I could not find a package that does the same.