Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop algorithms for gene deletion strategies for growth-coupled production #2427

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

MetNetComp
Copy link
Contributor

@MetNetComp MetNetComp commented Feb 10, 2025

Dear Administrator,

TrimGdel appropriately considers GPR rules and derives the minimal and maximal gene deletion strategies for growth-coupled production.

T. Tamura, "Trimming Gene Deletion Strategies for Growth-Coupled Production in Constraint-Based Metabolic Networks: TrimGdel," in IEEE/ACM Transactions on Computational Biology and Bioinformatics, vol. 20, no. 2, pp. 1540-1549, 2023.

Best regards,
Takeyuki Tamura,
Kyoto University, Japan.

  • Tested my code on my own machine
  • Followed the guidelines in the Contributing Guide
  • Selected develop as a target branch (top left drop-down menu)

(Note: You may replace [ ] with [X] to check the box)

@farid-zare farid-zare closed this Feb 18, 2025
@farid-zare farid-zare reopened this Feb 18, 2025
Copy link
Contributor

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️
235 188 0 47

No failed tests ✨

Github Test Reporter by CTRF 💚

Copy link
Member

@rmtfleming rmtfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove src/design/TrimGdel/e_coli_core.mat because that is in COBRA.models

Also ALL functions should have complete headers. See printFunctionIO

@rmtfleming
Copy link
Member

Also, please add test function to
https://github.com/opencobra/cobratoolbox/tree/master/test/verifiedTests
Also, is there a tutorial to help others understand how to use your code?
https://github.com/opencobra/COBRA.tutorials
See
https://opencobra.github.io/cobratoolbox/stable/contributing.html

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️
236 189 0 47

No failed tests ✨

Github Test Reporter by CTRF 💚

@MetNetComp
Copy link
Contributor Author

Dear Ronan

Thank you for your review.
I removed e_coli_core; added complete headers to all functions;
added the test function to /test/verifiedTests/.

Also, I tried to create a pull request for ~/COBRA.tutorials,
but it seems that I do not have permission.

Best regards,
Takeyuki

@MetNetComp
Copy link
Contributor Author

Also, I would like to add iML1515.mat and iMM904.mat to ~/COBRA.models/mat/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants