feat: Completing partials/sorries#21
Open
osmanyasar05 wants to merge 6 commits into
Open
Conversation
bollu
reviewed
Jun 5, 2026
bollu
left a comment
bollu
left a comment
There was a problem hiding this comment.
LGTM other than the refactoring which I think decreases the complexity :)
Co-authored-by: Siddharth <siddu.druid@gmail.com>
osmanyasar05
force-pushed
the
complete_sorries
branch
from
f6cdc6f to
a245f4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will introduce:
addBitfunction with termination proofeval_heap_addBit,eval_heap_removeBit,get_removeBit_of_ne.addBitdefinition, our FA/HA correctness theorems usingeval(namelyhalfAdder_correctandfullAdder_correct) will not hold anymore. These will be removed and replaced with new theorems that account for the wrap-around behavior (we already have these, but they depend on theorems that no longer hold with the newaddBitdefinition).