WIP - Implement Generalizer #1022
Draft
+1,179
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import SSA.Experimental.Bits.Fast.Defs | ||
| import SSA.Experimental.Bits.Fast.FiniteStateMachine | ||
| import SSA.Experimental.Bits.Fast.Attr | ||
| import SSA.Experimental.Bits.Fast.Decide |
There was a problem hiding this comment.
This tactic should not depend on Mathlib or SSA, no?
| (fun ix => inputs.map ⟨fun input => Inputs.mk ix input, by intros a b; simp⟩) | ||
| ⟨out, by | ||
| ⟨out, by |
There was a problem hiding this comment.
These changes seem unrelated, no?
There was a problem hiding this comment.
They are unrelated. My editor keeps removing these trailing whitespaces, which seems to be according to the setting here, but I'm not sure why they were present before.
There was a problem hiding this comment.
It might be worth to commit these whitespace separately, so this diff is clean and our codebase is also cleaner.
ineol
reviewed
Mar 31, 2025
| BVExpr.shiftRight (substituteBVExpr lhs) (substituteBVExpr rhs) | ||
| | .arithShiftRight lhs rhs => | ||
| BVExpr.arithShiftRight (substituteBVExpr lhs) (substituteBVExpr rhs) | ||
| | _ => bvExpr --TODO: handle other constructors? |
There was a problem hiding this comment.
Yeah, you need to handle all constructors which contain expressions
oluwatimilehin
force-pushed
the
exists-forall
branch
from
a972112 to
47493ff
Compare
…ins; constraint constants when bitshifts are involved; cleanup, etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.