-
Notifications
You must be signed in to change notification settings - Fork 23
feat: add minimal dockerfile #1352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Alive Statistics: 90 / 93 (3 failed) |
bollu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as the first version 😄
|
bitwuzla and leanSAT provided counterexample for theorem 3 in file gapinthcast_proof.lean |
| - docker cp temp-container:/code/lean-mlir/bv-evaluation/raw-data ./docker-results | ||
| - docker rm temp-container | ||
| $ docker load -i opencompl-ssa.tar | ||
| $ docker run -it siddudruid/opencompl-ssa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have siddudruid here? In fact, why do we change this file at all? Should we maybe name it artifact-conference-.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
tobiasgrosser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing. Thank you, @luisacicolini!
|
Thank you @luisacicolini for the artefact. Thank you @bollu for the review. I am happy to see this go in. Consider my comments suggestions but no blockers. |
|
Alive Statistics: 90 / 93 (3 failed) |
|
Alive Statistics: 90 / 93 (3 failed) |
1 similar comment
|
Alive Statistics: 90 / 93 (3 failed) |
|
Alive Statistics: 90 / 93 (3 failed) |
|
Alive Statistics: 90 / 93 (3 failed) |
1 similar comment
|
Alive Statistics: 90 / 93 (3 failed) |
…nto dockerfile-minimal
|
Alive Statistics: 90 / 93 (3 failed) |
|
bitwuzla and leanSAT provided counterexample for theorem 3 in file gapinthcast_proof.lean |
This PR adds a minimal dockerfile for the artifact evaluation. #898 had a rather large diff with main and included a few changes non strictly docker-related. However, for the time being, I'd like to start adding this minimal docker, which I will then update step-by-step as we finalize the structure of our evaluation.