Skip to content

Conversation

@bollu
Copy link
Contributor

@bollu bollu commented Mar 31, 2025

No description provided.

@compor
Copy link
Contributor

compor commented Apr 1, 2025

Hey @bollu what's the issue here? Could you please provide a short description of it?

@compor compor self-requested a review April 1, 2025 10:29
@bollu
Copy link
Contributor Author

bollu commented Apr 4, 2025

During paper deadline, we noticed that CI was spending ginormous amounts of time linting python scripts. I'm really not sure why this was the case. Here's the example: https://github.com/opencompl/paper-lean-bitvectors/actions/runs/14081736065/job/39436056097 where it takes 25min.

I suggest we delete yapf for this reason.

@compor
Copy link
Contributor

compor commented Apr 4, 2025

I see, thanks for that.

===============================================================================
 Language            Files        Lines         Code     Comments       Blanks
===============================================================================
 Dockerfile              1           33           24            4            5
 Makefile                4          109           63           16           30
 Markdown                3          353            0          242          111
 Nix                     1           56           45            5            6
 Org                    11          239          169            0           70
 Python                 10         3743         2909          314          520
 Shell                   4          585          431           81           73
 TeX                    38         3966         2730          761          475
 Plain Text              2           46            0           46            0
 VB6                     2         4879         4549            0          330
===============================================================================
 Total                  76        14009        10920         1469         1620
===============================================================================

I wouldn't expect ~3k lines of Python to have that effect, but yeah no issue.
We can revisit formatting later or leave it entirely to each paper.

@compor compor merged commit 6d945f8 into main Apr 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants