Use new upstream software development container#349
Open
colluca wants to merge 2 commits into
Open
Conversation
Collaborator
|
Looks like a real error in the CI: Do you see this locally if you run |
Collaborator
Author
|
I'm afraid I won't have time to fix the PR until end of the month. But I'll come back to this after that. |
Collaborator
|
No worries, I'll try to debug it before then |
Collaborator
Author
|
In that case, I pushed the fixes I started working on in the last commit, in case they might help |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft proposal to align with the latest software development container for Snitch.
While I copied over Snitch's dependencies (i.e. the Verilated Snitch model binary and the toolchain into your Docker container, it is not strictly necessary to actually "merge" them). This might actually cause problems down the line if the two base OSes diverge.
As mentioned in our meeting, shipping the Snitch repo inside the container is not very flexible, reason for which we departed from this solution upstream.
Obviously this requires that it is locally cloned and mounted in the container, see suggested usage.
My proposal would just be to submodule Snitch, but I'm not too familiar with this repo's structure and requirements, so I wait for your feedback on this.
This PR supersedes #340.