-
Notifications
You must be signed in to change notification settings - Fork 7
Transfer functions utils added, right now it only includes soundness checks #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b35e18a to
5175b61
Compare
math-fehr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
I added some comments, feel free to ask me any questions!
I think that some functions should be probably moved somewhere more appropriate, for instance the function creating AndOp, or the function creating a CallOp with a check.
Otherwise, please document the functions a bit more, so I can more easily understand what they do and how they do it!
5175b61 to
53d70a6
Compare
|
@math-fehr Hi Mathieu, I updated both files with comment, do you think I need to add more? |
|
Hey! Can you add them as docstrings with the |
|
And for functions/classes, the docstrings should be added directly in the function scope. |
math-fehr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments in the first file, can you please address some comments on the second file?
5c564e3 to
d0e9434
Compare
|
@math-fehr Thanks for your reviews! I accepted your changes, and updated my functions/fields as your suggested format. I think it's better now! |
|
@math-fehr 0w0 |
|
Sorry for the delay! |
|
@math-fehr It's totally OK >w< .Thanks for looking both files! I added more comment for the other file. What do you think now? |
1 similar comment
|
@math-fehr It's totally OK >w< .Thanks for looking both files! I added more comment for the other file. What do you think now? |
|
What I meant was addressing the comments I made earlier, like merging some functions, or removing some functions. They should be still on github, do you see them? |
No description provided.