Add SMT Tensor Dialect #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hatsunespica
force-pushed
the
tensor-merge
branch
from
85ff806 to
341376d
Compare
Hatsunespica
force-pushed
the
tensor-merge
branch
from
e5723fa to
b7ecd7c
Compare
math-fehr
reviewed
Sep 27, 2025
Contributor
math-fehr
left a comment
math-fehr
left a comment
There was a problem hiding this comment.
Nice! I put some comments, but otherwise that looks good to me!
Collaborator
Author
|
@math-fehr Please let me know if |
math-fehr
reviewed
Sep 27, 2025
Contributor
math-fehr
left a comment
math-fehr
left a comment
There was a problem hiding this comment.
Just two comments and that's good, thanks!
Collaborator
Author
|
@math-fehr Thanks for pointing it out! Both problems are fixed now |
Contributor
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two changes: