Skip to content

Update DWRR scheduler weight range #2188

Merged
tjchadaga merged 2 commits into
opencomputeproject:masterfrom
kperumalbfn:kperumal/dwrr_maxwt
Jul 21, 2025
Merged

Update DWRR scheduler weight range #2188
tjchadaga merged 2 commits into
opencomputeproject:masterfrom
kperumalbfn:kperumal/dwrr_maxwt

Conversation

@kperumalbfn

Copy link
Copy Markdown
Contributor

Current DWRR weight range is from 1-100, increase to 1-255 as some ASIC supports higher value.

@kperumalbfn
kperumalbfn force-pushed the kperumal/dwrr_maxwt branch from cc621a4 to f163c86 Compare July 18, 2025 17:29
@kperumalbfn

Copy link
Copy Markdown
Contributor Author

@JaiOCP could you please review

@kperumalbfn

Copy link
Copy Markdown
Contributor Author

@eddyk-nvidia could you please review

@JaiOCP JaiOCP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the assumption that review comment would be taken care off

Comment thread inc/saischeduler.h Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the comments reflecting the 8 bit value range 0..255, where 0 is invalid value

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JaiOCP Updated the range to 0...255 and 0 as invalid weight

Signed-off-by: Kumaresh Perumal <kperumal@microsoft.com>
Signed-off-by: Kumaresh Perumal <kperumal@microsoft.com>
@kperumalbfn
kperumalbfn force-pushed the kperumal/dwrr_maxwt branch from 29cce00 to 9ce6019 Compare July 18, 2025 21:09
@tjchadaga

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@tjchadaga

Copy link
Copy Markdown
Collaborator

@rajkumar38, @ashutosh-agrawal - please help get this reviewed

Comment thread inc/saischeduler.h
Comment thread inc/saischeduler.h
@kperumalbfn

Copy link
Copy Markdown
Contributor Author

@ashutosh-agrawal @itaibaz Could you please review and approve the PR

@itaibaz

itaibaz commented Jul 21, 2025

Copy link
Copy Markdown
Collaborator

I think there was already a suggestion to add a new switch attribute, dwrr weight range, uint8 range, that will reflect the HW capabilities, for example [1..100] or [1..255] and would allow the application to query that

@kperumalbfn

Copy link
Copy Markdown
Contributor Author

I think there was already a suggestion to add a new switch attribute, dwrr weight range, uint8 range, that will reflect the HW capabilities, for example [1..100] or [1..255] and would allow the application to query that

Thanks @itaibaz Max DWRR weight using switch capability will be added in the later PRs. This PR is a minor change to only update the comment.

@r12f r12f left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Kumaresh!

@ashutosh-agrawal ashutosh-agrawal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tjchadaga
tjchadaga merged commit b925fc0 into opencomputeproject:master Jul 21, 2025
3 checks passed
tjchadaga pushed a commit that referenced this pull request Jul 22, 2025
* Update DWRR weight range

Signed-off-by: Kumaresh Perumal <kperumal@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants