Skip to content

Create API for fast linkup configuration.#2203

Merged
prgeor merged 1 commit into
opencomputeproject:masterfrom
iamjustadd:dev_master_sai_fast_linkup
Sep 26, 2025
Merged

Create API for fast linkup configuration.#2203
prgeor merged 1 commit into
opencomputeproject:masterfrom
iamjustadd:dev_master_sai_fast_linkup

Conversation

@iamjustadd

@iamjustadd iamjustadd commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

Hi team,

This PR is for creating SAI API for FR fast linkup.

@iamjustadd
iamjustadd force-pushed the dev_master_sai_fast_linkup branch from 0693a69 to a62e203 Compare September 9, 2025 04:20
@bingwang-ms

bingwang-ms commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

@prgeor Can you help review?

@iamjustadd
iamjustadd force-pushed the dev_master_sai_fast_linkup branch 2 times, most recently from c5c2e4a to f69d599 Compare September 15, 2025 06:21
prgeor
prgeor reviewed Sep 15, 2025
View reviewed changes
Comment thread doc/SAI-Proposal-Fast-Linkup.md Outdated
prgeor
prgeor reviewed Sep 15, 2025
View reviewed changes
Comment thread inc/saiswitch.h Outdated
* @type sai_u16_range_t
* @flags READ_ONLY
*/
SAI_SWITCH_ATTR_FAST_LINKUP_POLLING_TIME_RANGE,

@prgeor prgeor Sep 15, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamjustadd What is the use case for this? How many samples will be used to derive the past link up time?

@eddyk-nvidia eddyk-nvidia Sep 15, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamjustadd What is the use case for this? How many samples will be used to derive the past link up time?

SAI_SWITCH_ATTR_FAST_LINKUP_POLLING_TIME_RANGE is used to obtain the range that can be used for configuration of SAI_SWITCH_ATTR_FAST_LINKUP_POLLING_TIME. Please clarify regarding the "samples" question

@iamjustadd iamjustadd Sep 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User should call SAI_SWITCH_ATTR_FAST_LINKUP_POLLING_TIME_RANGE before set FAST_LINKUP_POLLING_TIME. Different vendor may got different range.

@eddyk-nvidia eddyk-nvidia Sep 18, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User should call SAI_SWITCH_ATTR_FAST_LINKUP_POLLING_TIME_RANGE before set FAST_LINKUP_POLLING_TIME. Different vendor may got different range.

correct. It is the purpose of SAI_SWITCH_ATTR_FAST_LINKUP_POLLING_TIME_RANGE

prgeor
prgeor reviewed Sep 15, 2025
View reviewed changes
Comment thread inc/saiswitch.h Outdated
/**
* @brief Time (in secs) during which the link must be UP and have the BER below the level configured with SAI_SWITCH_ATTR_FAST_LINKUP_GUARD_TIME_BER to have the next linkup as fast link-up
*
* If either link failures or high BER event happen during the configured time then full link-up flow (not fast) will be used for next link-up.

@prgeor prgeor Sep 15, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamjustadd Which is the "configured time" referring to here?

@eddyk-nvidia eddyk-nvidia Sep 15, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamjustadd Which is the "configured time" referring to here?

SAI_SWITCH_ATTR_FAST_LINKUP_GUARD_TIME

prgeor
prgeor reviewed Sep 15, 2025
View reviewed changes
Comment thread inc/saiswitch.h
@iamjustadd
iamjustadd force-pushed the dev_master_sai_fast_linkup branch 2 times, most recently from 46db2be to bc82fce Compare September 16, 2025 08:06
@iamjustadd
iamjustadd requested a review from prgeor September 16, 2025 08:10
@iamjustadd
iamjustadd force-pushed the dev_master_sai_fast_linkup branch from bc82fce to 8f84bcf Compare September 19, 2025 01:14
@eddyk-nvidia

eddyk-nvidia commented Sep 19, 2025

Copy link
Copy Markdown

@prgeor , @JaiOCP - could you please approve the PR ? All comments at the community review were addressed. Thanks

prgeor
prgeor reviewed Sep 21, 2025
View reviewed changes
Comment thread inc/saiswitch.h Outdated
prgeor
prgeor reviewed Sep 21, 2025
View reviewed changes
Comment thread inc/saiswitch.h Outdated
@iamjustadd
iamjustadd force-pushed the dev_master_sai_fast_linkup branch from 8f84bcf to 62b4c9b Compare September 22, 2025 06:34
@iamjustadd
iamjustadd requested a review from prgeor September 22, 2025 06:35
@iamjustadd
iamjustadd force-pushed the dev_master_sai_fast_linkup branch 2 times, most recently from f8f9e35 to 0694b31 Compare September 22, 2025 06:43
@prgeor

prgeor commented Sep 22, 2025

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

azure-pipelines Bot commented Sep 22, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@prgeor

prgeor commented Sep 22, 2025

Copy link
Copy Markdown
Collaborator

@iamjustadd build failure. please fix

@tjchadaga tjchadaga added the reviewed PR is discussed in SAI Meeting label Sep 22, 2025
@iamjustadd
iamjustadd force-pushed the dev_master_sai_fast_linkup branch from 0694b31 to 0851a8f Compare September 23, 2025 06:54
@iamjustadd

iamjustadd commented Sep 23, 2025

Copy link
Copy Markdown
Contributor Author

@eddyk-nvidia @prgeor

  1. Previous brief of SAI_SWITCH_ATTR_FAST_LINKUP_BER_THRESHOLD is too long to pass the sanity check, I shorten the brief of it.
  2. Previously, metadata generator is not compitable with sai_u16_range_t, I fix it also in this PR.

Please help review on this.

Thanks.

@iamjustadd
iamjustadd requested a review from prgeor September 23, 2025 06:56
@prgeor

prgeor commented Sep 24, 2025

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

azure-pipelines Bot commented Sep 24, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@iamjustadd
iamjustadd force-pushed the dev_master_sai_fast_linkup branch from 0851a8f to 7eb56d2 Compare September 25, 2025 02:36
@iamjustadd

iamjustadd commented Sep 25, 2025

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

azure-pipelines Bot commented Sep 25, 2025

Copy link
Copy Markdown
Commenter does not have sufficient privileges for PR 2203 in repo opencomputeproject/SAI

@iamjustadd iamjustadd closed this Sep 25, 2025
@iamjustadd
iamjustadd force-pushed the dev_master_sai_fast_linkup branch from 7eb56d2 to 9658eeb Compare September 25, 2025 02:46
Create API for fast linkup configuration.
76531c4 
Signed-off-by: Martin Liao <marliao@marliao-mlt.client.nvidia.com>
@iamjustadd iamjustadd reopened this Sep 25, 2025
@prgeor

prgeor commented Sep 25, 2025

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

azure-pipelines Bot commented Sep 25, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

prgeor
prgeor reviewed Sep 25, 2025
View reviewed changes

@prgeor prgeor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JaiOCP any comments?

@prgeor
prgeor merged commit 401bd1f into opencomputeproject:master Sep 26, 2025
5 checks passed
tjchadaga pushed a commit that referenced this pull request Oct 10, 2025
@iamjustadd @tjchadaga
Create API for fast linkup configuration. (#2203)
3a71308 
Signed-off-by: Martin Liao <marliao@marliao-mlt.client.nvidia.com>
Co-authored-by: Martin Liao <marliao@marliao-mlt.client.nvidia.com>
@iamjustadd
iamjustadd deleted the dev_master_sai_fast_linkup branch November 5, 2025 04:15
@tjchadaga tjchadaga mentioned this pull request Jan 14, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prgeor prgeor prgeor approved these changes
+1 more reviewer
@eddyk-nvidia eddyk-nvidia eddyk-nvidia left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

reviewed PR is discussed in SAI Meeting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iamjustadd @bingwang-ms @eddyk-nvidia @prgeor @tjchadaga