Manually override HW switchover for planned operation#2210
Closed
chikkaiah-work wants to merge 9 commits into
Closed
Manually override HW switchover for planned operation#2210chikkaiah-work wants to merge 9 commits into
chikkaiah-work wants to merge 9 commits into
Conversation
chikkaiah-work
marked this pull request as ready for review
October 1, 2025 20:04
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@chikkaiah-work - could you please squash your commits to resolve the metachecker errors? Also, would you like to discuss this PR in the community meeting? |
Contributor
Author
|
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@JaiOCP - could you please help review this PR? |
Collaborator
|
@chikkaiah-work - could you please try to rebase your branch to the latest master? |
Contributor
Author
Done. Rebased to latest master. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Chikkegowda Chikkaiah <cchikkai@cisco.com> change name from bacup to standby Signed-off-by: Chikkegowda Chikkaiah <cchikkai@cisco.com> fixes Signed-off-by: Chikkegowda Chikkaiah <cchikkai@cisco.com> fix error Signed-off-by: Chikkegowda Chikkaiah <cchikkai@cisco.com>
Signed-off-by: Prince George <prgeor@microsoft.com> Signed-off-by: Chikkegowda Chikkaiah <cchikkai@cisco.com>
Signed-off-by: Running Huang <runningh@nvidia.com> Signed-off-by: Chikkegowda Chikkaiah <cchikkai@cisco.com>
Signed-off-by: Martin Liao <marliao@marliao-mlt.client.nvidia.com> Co-authored-by: Martin Liao <marliao@marliao-mlt.client.nvidia.com> Signed-off-by: Chikkegowda Chikkaiah <cchikkai@cisco.com>
The meta/Makefile contains several rules which are not correct
for parallel make. These rules contain several targets to the
left of the colon, and express the intent that the targets are
built together as a group. Unfortunately, that's not what the
syntax means: Rather:
t1 t2 t3 : prereq
recipe # recipe generates all three!
is essentially a syntactic sugar condensing multiple rules
with the same recipe and prerequisites:
t1 : prereq
recipe # recipe generates all three!
t2 : prereq
recipe
t3 : prereq
recipe
Under parallel make these rules fire in parallel which can
wreak havoc, since they stomp on each other's files.
The issue can be addressed using the grouped targets feature:
t1 t2 t3 &: prereq
recipe # recipe generates all three!
The ampersand-colon separator &: means that there is only one
rule here which Make understands to be updating all three
targets.
This feature has been available since GNU Make 4.2.90.
Ubuntu-latest is on 4.3.
(The grouped targets feature was the subject of a bugfix before
4.4. The bug potentially causes a grouped target not to be
remade if it is deleted. This is minor problem because it's
not expected that someone will be deleting, say, the generated
file saimetadata.c individually rather than doing a "make clean"
which deletes all the generated files.)
Signed-off-by: Kaz Kylheku <kazinator@arista.com>
Signed-off-by: Chikkegowda Chikkaiah <cchikkai@cisco.com>
This proposal outlines the addition of a new port attribute designed to provide a standardized method for querying the active firmware revision of a port. Proposal - Add label SAI_ATTR_PORT_FW_REVISION under sai_port_attr_h in saiport.h to store firmware related information. This attribute will store a string denoting the current firmware version running on the port. This can denote either the SerDes firmware version or any other vendor specific firmware version that needs to be exported. Signed-off-by: Tejas Pandey <pandeytejas@google.com> Signed-off-by: Chikkegowda Chikkaiah <cchikkai@cisco.com>
Signed-off-by: Dhruvkumar Patel <pdhruvkumarr@marvell.com> Signed-off-by: Chikkegowda Chikkaiah <cchikkai@cisco.com>
…iacl module) (#2202) Signed-off-by: Kandankarunai Thiruppathi <kthiruppathi@marvell.com> Signed-off-by: Chikkegowda Chikkaiah <cchikkai@cisco.com>
Contributor
|
@chikkaiah-work, |
Contributor
Author
Hi @rajkumar38, it got master branch diffs while squashing the commits. Hence closed it and opened new one - #2219 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need capability to switch to primary or backup manually overriding the hardware switchover. DualToR architecture in SONiC requires this manual switching capability without any packet loss for planned operation in the datacenter.
This will need a new SAI attribute in the nexthop protection group. Introducing a new enum attribute as admin_role {auto(default), primary, backup} which can override the hardware switching when not set as auto.