Change default value of ACL Counter attribute

[Shaigai21]

From inc/saiacl.h:

/*
 * By default, Byte Counter would be created and following
 * use of the below attributes would result in an error.
 *
 * - Both packet count and byte count set to disable
 * - Only Byte count used which is set to disable
 */

According to the comment above, default value for enabling byte count is true.

But for SAI_ACL_COUNTER_ATTR_ENABLE_BYTE_COUNT it is set to false:

/**
 * @brief Enable/disable byte count
 *
 * @type bool
 * @flags CREATE_ONLY
 * @default false
 */
SAI_ACL_COUNTER_ATTR_ENABLE_BYTE_COUNT,

[ibarnea]

I think it makes more sense to change default to true on packet count (or both), and fix the comment.
What does this comment mean? "Only Byte count used which is set to disable". I think it should be changed to "Only Byte count used". Meaning it is illegal to create a counter which counts only bytes and not packets.

[Shaigai21]

You should read the whole paragraph. "By default, Byte Counter would be created and following use of the below attributes would result in an error." So the cases below are ones that lead to an error: disabling byte count and not enabling packet count means that counter does not count anything. Only configurations with at least one enabled counter are allowed, but the Byte Counter is enabled by default.

[ibarnea]

OK. Understood. I agree that your change aligns with the comment