Skip to content

Added RS544 extended fec variants#2257

Open
pullaraogunda wants to merge 1 commit intoopencomputeproject:masterfrom
pullaraogunda:extended_fec_mode
Open

Added RS544 extended fec variants#2257
pullaraogunda wants to merge 1 commit intoopencomputeproject:masterfrom
pullaraogunda:extended_fec_mode

Conversation

@pullaraogunda
Copy link
Contributor

This PR introduces four new enums to sai_port_fec_mode_extended_t

@tjchadaga tjchadaga requested a review from prgeor February 24, 2026 18:30
@tjchadaga
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mobinmohan
Copy link

Thanks for taking care of this change. This is required for 200G PAM4.

@pullaraogunda
Copy link
Contributor Author

SAI_PORT_FEC_MODE_EXTENDED_RS544_INTERLEAVED_ETC :
This mode conforms to 800G ETC.
Link : https://ethernettechnologyconsortium.org/wp-content/uploads/2021/10/Ethernet-Technology-Consortium_800G-Specification_r1.1.pdf

SAI_PORT_FEC_MODE_EXTENDED_RS544_INTERLEAVED_IEEE :
This mode is conforms to CL172 of IEEE 802.3df (for 800Gx8-lane) and pre-draft 802.3dj (for 1.6Tx8, 800Gx4, 400Gx2, 200Gx1)
Link to 802.3df : https://ieeexplore.ieee.org/document/10472445
Link to 802.3dj : https://standards.ieee.org/ieee/802.3dj/11115/

ETC and IEEE vary only in bitmux. IEEE specifies that the 4:1 bitmux must contain 2 FEC lanes from flow-0 (lanes 0-15) and two FEC lanes from flow-1 (lanes 16-31). The ETC spec implies bitmuxing is restricted within the two sets of FEC lanes (lanes 0-15 and lanes 16-31). These two modes can interop with each other.

SAI_PORT_FEC_MODE_EXTENDED_RS544_LOW_LATENCY :
This mode is a low latency variant of SAI_PORT_FEC_MODE_EXTENDED_RS544 that has a 1:1 ratio of FEC lanes to physical lanes and does symbol distribution to FEC lanes with no bit multiplexing.

Copy link

@mobinmohan mobinmohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this.

inc/saiport.h Outdated
SAI_PORT_FEC_MODE_EXTENDED_RS544_INTERLEAVED_ETC,

/** Enable RS544-FEC (interleaved-CL172) IEEE 802.3df variant */
SAI_PORT_FEC_MODE_EXTENDED_RS544_INTERLEAVED_IEEE,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look for whether we can use a name that is less ambiguous than "IEEE" here since SAI_PORT_FEC_MODE_EXTENDED_RS544_INTERLEAVED is also an IEEE spec

@pullaraogunda
Copy link
Contributor Author

Renamed SAI_PORT_FEC_MODE_EXTENDED_RS544_INTERLEAVED_IEEE to SAI_PORT_FEC_MODE_EXTENDED_RS544_INTERLEAVED_CL172.

SAI_PORT_FEC_MODE_EXTENDED_RS544_INTERLEAVED confirms to IEEE 802.3bs standard (Clause 119) used for 200G/400G.
This new fec mode SAI_PORT_FEC_MODE_EXTENDED_RS544_INTERLEAVED_IEEE confirms to IEEE 802.3df standard (Clause 172) used for 800G+ports.

@tjchadaga
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tjchadaga
Copy link
Collaborator

@pullaraogunda - could you please squash your commits and force push to ensure meta check passes?

Signed-off-by: pullarao <pullarao.gunda@broadcom.com>
@pullaraogunda
Copy link
Contributor Author

@tjchadaga squashed the commits. Please check and integrate it

@tjchadaga
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants