Fix nvme-cli csts parsing for hexadecimal output #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some control files use nvme-cli version 2.6.4, where the csts value is output as "csts : 1" even though it represents a hexadecimal value (%x format). Later versions and the latest release output the value with a "0x" prefix (e.g., "csts : 0x1"). Update the parser to correctly interpret the csts value as hexadecimal regardless of the format. Signed-off-by: Steven Seungcheol Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some control files use nvme-cli version 2.6.4,
where the csts value is output as "csts : 1" even though it represents a hexadecimal value (%x format). Later versions and the latest release output the value with a "0x" prefix (e.g., "csts : 0x1").
Update the parser to correctly interpret the csts value as hexadecimal regardless of the format.