TE-14.2 fix logics & added repaired_vrf#4531
Open
snaragund wants to merge 10 commits intoopenconfig:mainfrom
Open
TE-14.2 fix logics & added repaired_vrf#4531snaragund wants to merge 10 commits intoopenconfig:mainfrom
snaragund wants to merge 10 commits intoopenconfig:mainfrom
Conversation
- Added vrf_repaired as vrf_r config without vrf_rd is not logical.
- Removed ! with deviations.DecapNHWithNextHopNIUnsupported.
- Under deviations.ExplicitInterfaceInDefaultVRF(dut) included DefaultVRFIPv4NHCount while configuring NHs.
- Under BuildVRFCfonfig function added missing code which was included in TE-14.1.
- For Nokia vendor added decapIPv4ScaleCount=128.
- Added `override_default_nh_scale` deviation.
- Existing scale.go configures 29254 NHs where as many NHs are unused so changed logic to configure NHs which are needed(9511 NHs).
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
Pull Request Functional Test Report for #4531 / f5faabdVirtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 20075354414Details
💛 - Coveralls |
Contributor
Author
|
@ram-mac could you please review |
ram-mac
requested changes
Oct 29, 2025
internal/tescale/scale.go
Outdated
| ) | ||
| if idx != 0 && idx%reEncapNHGRatio == 0 { | ||
| vrfDefault.NHGs = append(vrfDefault.NHGs, nhgEntry) | ||
| if idx%reEncapNHGRatio == 0 { |
Contributor
There was a problem hiding this comment.
@snaragund - I know you have optimized the NH scale usage. But i would like to keep this scale on the device for now and not make any changes. Let there be unutilized NH, it is not impacting the functionality anyways.
Contributor
Author
There was a problem hiding this comment.
@ram-mac Reverted back without optimization, now it will have 29254 NHs, 1543 NHGs. With optimized code it was 9511 NHs, 1287 NHGs.
| func installDecapEntry(t *testing.T, args *testArgs, nhIndex, nhgIndex uint64, prefix string) { | ||
| decapNH := fluent.NextHopEntry().WithNetworkInstance(deviations.DefaultNetworkInstance(args.dut)). | ||
| WithIndex(nhIndex).WithDecapsulateHeader(fluent.IPinIP) | ||
| if !deviations.DecapNHWithNextHopNIUnsupported(args.dut) { |
Contributor
There was a problem hiding this comment.
@snaragund - Why are we removing this deviation statement? Also, I see this deviation is not used by Nokia. This break other vendor tests. Can we please revert this change?
Contributor
Author
There was a problem hiding this comment.
@ram-mac Deviation statement default value is false hence deviation should have been defined with else condition instead of !deviation. We support decap NH without NI.
-Reverting changes of deviation definition as per comment by Ram.
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
override_default_nh_scaledeviation."This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."