RT-1.31 bgp_3level_nested_policy_test.go

[cprabha]

Hi,

Below are the modifications done in RT-1.31.

1.) PERMIT ALL route policy is not required, we can enable default accept policy, this will only allow BGP routes.
Explicit PERMIT ALL route policy will allow non bgp routes as well.

2.) Added clean up policy after each test , in case if any of subtest fails, it does not retain policy and that will cause failure in next sub testcase.

3.) Enabled one prefix in invert route filter policy so make sure invert works fine for required prefix.

4.) In each of nested policy we need ACCEPT (this is similar to RT-7.11, please check RT-7.11)

5.) By default, Ebgp does not accept routes , default value is REJECT. Hence explicit ACCEPT is needed to import routes.

Thanks,
Prabha

[gemini-code-assist]

Summary of Changes

Hello @cprabha, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refines the BGP 3-level nested policy tests by streamlining policy configurations and enhancing test reliability. The changes ensure that BGP routes are handled correctly by default policies, prevent test interference through robust cleanup mechanisms, and validate specific policy behaviors like invert route filtering. These updates contribute to more accurate and stable testing of BGP routing policies.

Highlights

• Policy Simplification: Removed the explicit "PERMIT ALL" route policy, opting for the default accept policy for BGP routes to prevent unintended acceptance of non-BGP routes.
• Test Stability: Introduced cleanup policies after each subtest to ensure that policies are not retained, preventing failures in subsequent test cases.
• Invert Filter Validation: Enabled a specific prefix within the invert route filter policy to thoroughly verify its functionality.
• Nested Policy Actions: Modified nested policy statements to explicitly "ACCEPT_ROUTE" instead of "NEXT_STATEMENT", aligning with expected behavior for route acceptance.
• EBGP Default Acceptance: Explicitly configured EBGP neighbors to "ACCEPT_ROUTE" by default for import policies, addressing the default "REJECT" behavior.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #4936 / 70d8402

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-1.31: BGP 3 levels of nested import/export policy with match-set-options
Cisco 8000E		RT-1.31: BGP 3 levels of nested import/export policy with match-set-options
Cisco XRd		RT-1.31: BGP 3 levels of nested import/export policy with match-set-options
Juniper ncPTX		RT-1.31: BGP 3 levels of nested import/export policy with match-set-options
Nokia SR Linux		RT-1.31: BGP 3 levels of nested import/export policy with match-set-options
Openconfig Lemming		RT-1.31: BGP 3 levels of nested import/export policy with match-set-options

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-1.31: BGP 3 levels of nested import/export policy with match-set-options
Cisco 8808		RT-1.31: BGP 3 levels of nested import/export policy with match-set-options
Juniper PTX10008		RT-1.31: BGP 3 levels of nested import/export policy with match-set-options
Nokia 7250 IXR-10e		RT-1.31: BGP 3 levels of nested import/export policy with match-set-options

Help

[gemini-code-assist]

Code Review

This pull request introduces several valuable improvements to the BGP nested policy test. The addition of cleanup logic for each subtest significantly enhances test isolation and reliability. The switch from an explicit PERMIT-ALL policy to using default BGP policies simplifies the configuration and aligns better with real-world scenarios. The corrections to policy actions (using ACCEPT_ROUTE instead of NEXT_STATEMENT) and the explicit configuration of default import policies address key behavioral aspects of BGP routing. My review includes suggestions to address violations of the repository's IP addressing style guide and to refactor duplicated cleanup functions for better maintainability.

[coveralls]

Pull Request Test Coverage Report for Build 20256658540

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 10.034%

---

Totals
Change from base Build 20216431356:	0.0%
Covered Lines:	2227
Relevant Lines:	22195

---

💛 - Coveralls

[cprabha]

@ram-mac Please could you review and help to merge this git pull request.