BMP-2.7: BMP Pre Policy Test

[ANISH-GOTTAPU]

BMP-2.7: BMP Pre Policy Test with OTG

Log: https://partnerissuetracker.corp.google.com/issues/415458482#comment147

[OpenConfigBot]

Pull Request Functional Test Report for #4943 / 31ffd26

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		BMP-2.7: BMP Pre Policy Test
Cisco 8000E		BMP-2.7: BMP Pre Policy Test
Cisco XRd		BMP-2.7: BMP Pre Policy Test
Juniper ncPTX		BMP-2.7: BMP Pre Policy Test
Nokia SR Linux		BMP-2.7: BMP Pre Policy Test
Openconfig Lemming		BMP-2.7: BMP Pre Policy Test

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		BMP-2.7: BMP Pre Policy Test
Cisco 8808		BMP-2.7: BMP Pre Policy Test
Juniper PTX10008		BMP-2.7: BMP Pre Policy Test
Nokia 7250 IXR-10e		BMP-2.7: BMP Pre Policy Test

Help

[gemini-code-assist]

Summary of Changes

Hello @ANISH-GOTTAPU, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on expanding the testing capabilities for BGP Monitoring Protocol (BMP) by adding a new test case that verifies pre-policy route monitoring. It also refines the underlying BGP configuration utilities to offer more granular control over route limits and policy application for neighbors. A significant addition is the new BMP configuration plugin, which addresses current OpenConfig model gaps by implementing BMP setup via CLI, ensuring broader compatibility across different network devices.

Highlights

• New BMP Pre-Policy Test: A new Go test file (bmp_pre_policy_test.go) has been introduced to validate BGP Monitoring Protocol (BMP) pre-policy route monitoring using Open Traffic Generator (OTG).
• BGP Configuration Enhancements: The BGPConfig struct now includes options for enabling maximum routes and specifying peer groups, while BGPNeighborConfig allows for policy application per neighbor.
• BMP Configuration Plugin: A new bmp.go plugin has been added to facilitate BMP station configuration on the DUT, initially utilizing CLI commands due to current OpenConfig model limitations.
• Platform Deviations for BMP: Metadata and deviation handling have been updated to include bmp_oc_unsupported, specifically noting that Arista platforms currently require CLI for BMP configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new test for BMP pre-policy monitoring, along with necessary helper functions and configuration updates. The changes are well-structured and the new test provides valuable coverage. I've included several suggestions to improve the test's robustness, maintainability, and adherence to the repository's style guide. Key recommendations include correcting prefix count constants for verification, replacing a time.Sleep with a more robust gnmi.Watch, using defined constants for timeouts, and making critical test assertions fatal to ensure clearer, faster test failures.

[coveralls]

Pull Request Test Coverage Report for Build 20808735841

Details

• 0 of 21 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.005%) to 9.961%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/cfgplugins/bgp.go	0	21	0.0%

Totals
Change from base Build 20800861614:	-0.005%
Covered Lines:	2227
Relevant Lines:	22357

---

💛 - Coveralls

[ANISH-GOTTAPU]

@ram-mac : As discussed in the other PRs for BMP, shared the config for DUT and OTG.