Audit and add missing deviation flags to list of deviations #4952
Conversation
…added to deviations.textproto
Summary of ChangesHello @RishabhAgarwal-2001, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an audit of existing and missing deviation flags within the system. It primarily focuses on correcting a widespread typo in the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request corrects a typo in the network_instance_import_export_policy_oc_unsupported deviation flag and adds several new deviations as part of an audit. The changes are straightforward and correctly apply the typo fix across multiple files. However, all newly added deviations in internal/deviations/deviations.textproto are missing the required issue_url. The repository's contribution guidelines state that each deviation should have an associated issue tracker URL to facilitate tracking its eventual removal. Please add the appropriate issue URLs for all new deviations.
| } | ||
| } | ||
| platforms: { | ||
| issue_url: "" |
There was a problem hiding this comment.
The issue_url is empty. As per the repository's deviation guidelines, a URL to an issue tracker should be provided to track the removal of this deviation.
References
- Deviation guidelines require an
issue_urlto track the removal of the deviation. Seeinternal/deviations/README.md, lines 83-86. (link)
| } | ||
| } | ||
| platforms: { | ||
| issue_url: "" |
There was a problem hiding this comment.
The issue_url is empty. As per the repository's deviation guidelines, a URL to an issue tracker should be provided to track the removal of this deviation.
References
- Deviation guidelines require an
issue_urlto track the removal of the deviation. Seeinternal/deviations/README.md, lines 83-86. (link)
| } | ||
| } | ||
| platforms: { | ||
| issue_url: "" |
There was a problem hiding this comment.
The issue_url is empty. As per the repository's deviation guidelines, a URL to an issue tracker should be provided to track the removal of this deviation.
References
- Deviation guidelines require an
issue_urlto track the removal of the deviation. Seeinternal/deviations/README.md, lines 83-86. (link)
| } | ||
| } | ||
| platforms: { | ||
| issue_url: "" |
There was a problem hiding this comment.
The issue_url is empty. As per the repository's deviation guidelines, a URL to an issue tracker should be provided to track the removal of this deviation.
References
- Deviation guidelines require an
issue_urlto track the removal of the deviation. Seeinternal/deviations/README.md, lines 83-86. (link)
| } | ||
| } | ||
| platforms: { | ||
| issue_url: "" |
There was a problem hiding this comment.
The issue_url is empty. As per the repository's deviation guidelines, a URL to an issue tracker should be provided to track the removal of this deviation.
References
- Deviation guidelines require an
issue_urlto track the removal of the deviation. Seeinternal/deviations/README.md, lines 83-86. (link)
| } | ||
| } | ||
| platforms: { | ||
| issue_url: "" |
There was a problem hiding this comment.
The issue_url is empty. As per the repository's deviation guidelines, a URL to an issue tracker should be provided to track the removal of this deviation.
References
- Deviation guidelines require an
issue_urlto track the removal of the deviation. Seeinternal/deviations/README.md, lines 83-86. (link)
4 participants
This PR covers the auditing efforts for the following deviation flags -
Also fixes #4947