Add deviation for explicit BGP RIB streaming config #4955
Conversation
Following BGP tests verify the BGP RIB state streamed through following YANG path: /network-instances/network-instance/protocols/protocol/bgp/rib Arista devices need explicit BGP RIB streaming config to send data for the above YANG path.
Summary of ChangesHello @akalluru1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the testing framework by introducing a mechanism to handle device-specific requirements for BGP RIB streaming. It adds a new deviation to explicitly configure BGP RIB streaming on platforms like Arista, which otherwise would not stream the necessary data for BGP tests. This ensures that BGP feature tests can run successfully across a wider range of network devices by accommodating their unique configuration needs. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a deviation for Arista devices to enable BGP RIB streaming, which is necessary for certain BGP tests. The changes are applied consistently across several test files.
My review has identified a couple of areas for improvement:
- In
internal/cfgplugins/bgp.go, the new deviation helper function returns an error that is not handled by its callers. I've suggested modifying the function to fatal on error, which is a safer pattern. - The new deviation accessor in
internal/deviations/deviations.gois missing a required issue tracker URL in its documentation, which violates the repository's style guide.
Overall, the changes are logical and well-structured. Addressing these points will enhance the code's robustness and adherence to project standards.
The function DeviationBgpRibStreamingConfigRequired is defined to return an error, but none of the call sites in this pull request check for it. This can lead to silent failures if the deviation is ever enabled for an unsupported vendor. To make the code safer and more aligned with other test helpers, please consider changing the function to call t.Fatalf for unhandled vendors instead of returning an error. This will also simplify the call sites. Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
/fptest virtual |
Pull Request Test Coverage Report for Build 20768297631Details
💛 - Coveralls |
"unnecessary use of fmt.Sprintf" in internal/cfgplugins/bgp.go:685 remove `fmt.Sprintf`
4 participants
Multiple BGP tests verify the BGP RIB state streamed through following YANG path: /network-instances/network-instance/protocols/protocol/bgp/rib
Arista devices need explicit BGP RIB streaming config to send data for the above YANG path.