Skip to content

Conversation

@sachendras
Copy link
Contributor

Changes to convert v4 transport on GUE tunnel to IPv6 transport

Changes to convert v4 transport on GUE tunnel to IPv6 transport
@sachendras sachendras requested a review from a team as a code owner December 23, 2025 06:09
@sachendras
Copy link
Contributor Author

/gemini review

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sachendras, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant upgrade by transitioning the GUE tunnel transport mechanism from IPv4 to IPv6. The changes ensure that static route-based GUE encapsulation tests are fully compatible with and utilize an IPv6 networking environment. This involves comprehensive updates to both the test documentation and the underlying network configuration, aligning the system with modern internet protocol standards.

Highlights

  • IPv6 GUE Tunnel Migration: The primary change involves converting the GUE (Generic UDP Encapsulation) tunnel transport from IPv4 to IPv6, updating all relevant configurations and documentation.
  • Configuration and Address Updates: All IP addresses for GUE tunnel destinations, LAG interfaces, and static routes have been updated to their IPv6 counterparts. The JSON configuration schema for network instances and encapsulation headers has been adjusted to reflect UDPV6.
  • Documentation Alignment: The README.md file has been thoroughly revised to accurately describe the new IPv6-based test setup, including updated IP addresses, interface configurations, and verification steps, such as changing 'ICMP Time Exceeded' to 'ICMPv6 Time Exceeded'.
  • Hashing Tolerance Refinement: The tolerance values for ECMP and LAG hashing in the test verification steps have been refined from '6%' to '<6%'.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation to reflect the use of IPv6 transport for GUE tunnels, replacing previous IPv4 references. The changes are mostly correct and improve clarity. However, I've found a couple of issues in the README.md file: an incorrect ICMPv6 message type and a block of OpenConfig paths that are inconsistent with the updated JSON model presented in the same file. My review includes suggestions to correct these documentation errors.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation to reflect a change from IPv4 to IPv6 for GUE tunnel transport. The changes are generally good and include fixes for some pre-existing typos and an update to the canonical OpenConfig JSON structure. However, I've identified an issue where the list of OpenConfig paths for test coverage has not been fully updated to match the new JSON structure, which could affect automated test coverage reporting.

@coveralls
Copy link

coveralls commented Dec 23, 2025

Pull Request Test Coverage Report for Build 20483411947

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 753 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.004%) to 10.03%

Files with Coverage Reduction New Missed Lines %
internal/deviations/deviations.go 3 0.0%
internal/cfgplugins/interface.go 27 0.0%
proto/metadata_go_proto/metadata.pb.go 723 0.0%
Totals Coverage Status
Change from base Build 20452235155: -0.004%
Covered Lines: 2227
Relevant Lines: 22203

💛 - Coveralls

sachendras and others added 2 commits December 24, 2025 01:41
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@dbarney1106 dbarney1106 self-requested a review January 6, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants