do not merge #4963
do not merge #4963
Conversation
Summary of ChangesHello @dracazacula, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, explicitly marked as "do not merge", temporarily disables a significant portion of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Pull Request Functional Test Report for #4963 / effffdfVirtual Devices
Hardware Devices
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request comments out several tests within TestGribiDecap. Given the 'do not merge' title, this is likely for temporary debugging. My review provides a suggestion for a better practice of temporarily disabling tests using t.Skip(), which improves visibility in test reports compared to commenting out code. If the tests are meant to be permanently disabled, they should be removed instead.
| // t.Run("Test-2: match on source, protocol and DSCP, VRF_DECAP hit -> VRF_ENCAP_A miss -> DEFAULT", func(t *testing.T) { | ||
| // testGribiDecapMatchSrcProtoDSCP(ctx, t, dut, args) | ||
| // }) | ||
|
|
||
| t.Run("Test-3: Mixed Prefix Decap gRIBI Entries", func(t *testing.T) { | ||
| testGribiDecapMixedLenPref(ctx, t, dut, args) | ||
| }) | ||
| // t.Run("Test-3: Mixed Prefix Decap gRIBI Entries", func(t *testing.T) { | ||
| // testGribiDecapMixedLenPref(ctx, t, dut, args) | ||
| // }) | ||
|
|
||
| t.Log("Delete vrf selection policy W and Apply vrf selectioin policy C") | ||
| configureVrfSelectionPolicyC(t, dut) | ||
| // t.Log("Delete vrf selection policy W and Apply vrf selectioin policy C") | ||
| // configureVrfSelectionPolicyC(t, dut) | ||
|
|
||
| t.Run("Test-4: Tunneled traffic with no decap", func(t *testing.T) { | ||
| testTunnelTrafficNoDecap(ctx, t, dut, args) | ||
| }) | ||
| // t.Run("Test-4: Tunneled traffic with no decap", func(t *testing.T) { | ||
| // testTunnelTrafficNoDecap(ctx, t, dut, args) | ||
| // }) | ||
|
|
||
| t.Log("Delete vrf selection policy C and Apply vrf selectioin policy W") | ||
| configureVrfSelectionPolicyW(t, dut) | ||
| // t.Log("Delete vrf selection policy C and Apply vrf selectioin policy W") | ||
| // configureVrfSelectionPolicyW(t, dut) | ||
|
|
||
| t.Run("Test-5: Match on default term and send to default VRF", func(t *testing.T) { | ||
| testTunnelTrafficMatchDefaultTerm(ctx, t, dut, args) | ||
| }) | ||
| // t.Run("Test-5: Match on default term and send to default VRF", func(t *testing.T) { | ||
| // testTunnelTrafficMatchDefaultTerm(ctx, t, dut, args) | ||
| // }) | ||
|
|
||
| t.Run("Test-6: Decap then encap", func(t *testing.T) { | ||
| testTunnelTrafficDecapEncap(ctx, t, dut, args) | ||
| }) | ||
| // t.Run("Test-6: Decap then encap", func(t *testing.T) { | ||
| // testTunnelTrafficDecapEncap(ctx, t, dut, args) | ||
| // }) |
There was a problem hiding this comment.
This change comments out several sub-tests. While this is acceptable for a temporary 'do-not-merge' pull request, this approach should not be merged. If these tests are intended to be permanently disabled, the code should be removed entirely. If they are temporarily disabled for a mergeable PR, consider using t.Skip() inside the test functions to make the intent clearer in test logs. For example:
t.Run("Test-2: ...", func(t *testing.T) {
t.Skip("Skipping test temporarily for debugging purposes.")
testGribiDecapMatchSrcProtoDSCP(ctx, t, dut, args)
})This provides better visibility in test reports by explicitly marking tests as skipped.
|
/fptest virtual |
Pull Request Test Coverage Report for Build 20572688893Details
💛 - Coveralls |
3 participants
do not merge