ipv6 rule in VRF selection policy

[dracazacula]

Create Ipv6 rules in VRF selection policy entries. Previously Ipv4 rules were instantiated, making some vendors fail tests due to duplicated rules.

[gemini-code-assist]

Summary of Changes

Hello @dracazacula, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical logic error in the VRF selection policy generation. Previously, when the system encountered IPv6-specific policy rules, it would mistakenly attempt to create an IPv4 protocol configuration. The change ensures that the correct IPv6 protocol object is created, which is essential for the accurate application and enforcement of IPv6-based VRF selection policies.

Highlights

• IPv6 VRF Policy Rule Correction: Corrected the logic within the VRF selection policy builder to ensure that an IPv6 protocol object (GetOrCreateIpv6) is properly instantiated when processing IPv6-specific policy rules, rather than incorrectly defaulting to an IPv4 object.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #4964 / cf33caa

No tests identified for validation.

Help

[gemini-code-assist]

Code Review

The pull request fixes a bug in internal/vrfpolicy/vrfpolicy.go by changing a call from pfR.GetOrCreateIpv4() to pfR.GetOrCreateIpv6() within an else block, ensuring that IPv6 protocol rules are correctly processed.

[coveralls]

Pull Request Test Coverage Report for Build 20598466017

Details

• 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 10.03%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/vrfpolicy/vrfpolicy.go	0	1	0.0%

Totals
Change from base Build 20581085943:	0.0%
Covered Lines:	2227
Relevant Lines:	22203

---

💛 - Coveralls