Clean up README PF-.17 by removing incorrect OC paths for macsec counters

[dplore]

Removed commented-out OC paths related to MACsec interface counters.

These counters are already covered:
``
#/macsec/interfaces/interface/state/counters/rx-pkts-ctrl: #/macsec/interfaces/interface/state/counters/rx-pkts-data: #/macsec/interfaces/interface/state/counters/rx-pkts-dropped: #/macsec/interfaces/interface/state/counters/rx-pkts-err-in: #/macsec/interfaces/interface/state/counters/tx-pkts-ctrl: #/macsec/interfaces/interface/state/counters/tx-pkts-data: #/macsec/interfaces/interface/state/counters/tx-pkts-dropped: #/macsec/interfaces/interface/state/counters/tx-pkts-err-in:

By these counters:

/macsec/interfaces/interface/state/counters/tx-untagged-pkts:
/macsec/interfaces/interface/state/counters/rx-untagged-pkts:
/macsec/interfaces/interface/state/counters/rx-badtag-pkts:
/macsec/interfaces/interface/state/counters/rx-unknownsci-pkts:
/macsec/interfaces/interface/state/counters/rx-nosci-pkts:
/macsec/interfaces/interface/state/counters/rx-late-pkts:
/macsec/interfaces/interface/scsa-tx/scsa-tx/state/sci-tx:
/macsec/interfaces/interface/scsa-tx/scsa-tx/state/counters/sc-auth-only:
/macsec/mka/state/counters/out-mkpdu-errors:
/macsec/mka/state/counters/in-mkpdu-icv-verification-errors:
/macsec/mka/state/counters/in-mkpdu-validation-errors:
/macsec/mka/state/counters/in-mkpdu-bad-peer-errors:
/macsec/mka/state/counters/in-mkpdu-peer-list-errors:
/macsec/mka/state/counters/sak-generation-errors:
/macsec/mka/state/counters/sak-hash-errors:
/macsec/mka/state/counters/sak-encryption-errors:
/macsec/mka/state/counters/sak-decryption-errors:
/macsec/mka/state/counters/sak-cipher-mismatch-errors:

[gemini-code-assist]

Summary of Changes

Hello @dplore, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the documentation by removing outdated and incorrect OpenConfig paths related to MACsec interface counters from the README.md file. The change ensures that the documentation accurately reflects the available counter paths, thereby improving clarity and preventing potential confusion for users referencing the file.

Highlights

• Documentation Cleanup: Removed a block of commented-out, incorrect OpenConfig (OC) paths for MACsec interface counters from the README.md file.
• Accuracy Improvement: The removed paths were redundant or incorrect, as the relevant MACsec counters are already covered by other specified paths, improving the accuracy of the documentation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #4972 / 055542c

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		PF-1.17: MPLSoGRE and MPLSoGUE MACsec	976ec9e0	Log
Cisco 8000E		PF-1.17: MPLSoGRE and MPLSoGUE MACsec	f63148fd	Log
Cisco XRd		PF-1.17: MPLSoGRE and MPLSoGUE MACsec	330e996b	Log
Juniper ncPTX		PF-1.17: MPLSoGRE and MPLSoGUE MACsec	961a6ea0	Log
Nokia SR Linux		PF-1.17: MPLSoGRE and MPLSoGUE MACsec	95bb397d	Log
Openconfig Lemming		PF-1.17: MPLSoGRE and MPLSoGUE MACsec	712a25ae	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		PF-1.17: MPLSoGRE and MPLSoGUE MACsec
Cisco 8808		PF-1.17: MPLSoGRE and MPLSoGUE MACsec
Juniper PTX10008		PF-1.17: MPLSoGRE and MPLSoGUE MACsec
Nokia 7250 IXR-10e		PF-1.17: MPLSoGRE and MPLSoGUE MACsec

Help

[gemini-code-assist]

Code Review

This pull request removes several incorrect and commented-out OpenConfig paths for MACsec interface counters from the README.md file. The change is a good cleanup as these paths are already covered by other existing counters, as noted in the description. The change is correct and improves the clarity of the test documentation. I have no further comments.

[coveralls]

Pull Request Test Coverage Report for Build 20729494401

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 10.023%

---

Totals
Change from base Build 20704703562:	0.0%
Covered Lines:	2227
Relevant Lines:	22219

---

💛 - Coveralls