Skip to content

Conversation

@divyarema
Copy link
Contributor

Added deviations,

isis_level_enabled (More details under,b/302661486)
multipath_unsupported_neighbor_or_afisafi (More details under,b/341130490)

@divyarema divyarema requested a review from a team as a code owner January 6, 2026 07:34
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @divyarema, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the AFT-1.3 test configuration by incorporating specific platform exceptions. The purpose is to account for known behaviors or limitations on Juniper devices related to ISIS level enablement and multipath support, thereby preventing potential false negatives or irrelevant test failures during the "AFTs collector Flap" test.

Highlights

  • New Deviations Added: Introduced two new deviations, "isis_level_enabled" and "multipath_unsupported_neighbor_or_afisafi", to the AFT-1.3 test configuration.
  • Platform-Specific Exceptions: These deviations are specifically applied as "platform_exceptions" for the "JUNIPER" vendor, ensuring test compatibility with Juniper devices.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link

Pull Request Functional Test Report for #4973 / 6c47d67

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
AFT-1.3: AFTs collector Flap
Cisco 8000E status
AFT-1.3: AFTs collector Flap
Cisco XRd status
AFT-1.3: AFTs collector Flap
Juniper ncPTX status
AFT-1.3: AFTs collector Flap
Nokia SR Linux status
AFT-1.3: AFTs collector Flap
Openconfig Lemming status
AFT-1.3: AFTs collector Flap

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
AFT-1.3: AFTs collector Flap
Cisco 8808 status
AFT-1.3: AFTs collector Flap
Juniper PTX10008 status
AFT-1.3: AFTs collector Flap
Nokia 7250 IXR-10e status
AFT-1.3: AFTs collector Flap

Help

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds two platform-specific deviations for Juniper devices in the AFT collector flap test. The changes in metadata.textproto enable isis_level_enabled and multipath_unsupported_neighbor_or_afisafi, which is necessary for the test to run correctly on Juniper hardware. The implementation aligns with the project's guidelines for managing deviations. The changes are correct and well-contained.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 20741494849

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 10.023%

Totals Coverage Status
Change from base Build 20733317624: 0.0%
Covered Lines: 2227
Relevant Lines: 22219

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants