-
Notifications
You must be signed in to change notification settings - Fork 197
Adding deviations for AFT1.3-AFTs collector Flap #4973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @divyarema, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the AFT-1.3 test configuration by incorporating specific platform exceptions. The purpose is to account for known behaviors or limitations on Juniper devices related to ISIS level enablement and multipath support, thereby preventing potential false negatives or irrelevant test failures during the "AFTs collector Flap" test. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Pull Request Functional Test Report for #4973 / 6c47d67Virtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds two platform-specific deviations for Juniper devices in the AFT collector flap test. The changes in metadata.textproto enable isis_level_enabled and multipath_unsupported_neighbor_or_afisafi, which is necessary for the test to run correctly on Juniper hardware. The implementation aligns with the project's guidelines for managing deviations. The changes are correct and well-contained.
Pull Request Test Coverage Report for Build 20741494849Details
💛 - Coveralls |
Added deviations,
isis_level_enabled (More details under,b/302661486)
multipath_unsupported_neighbor_or_afisafi (More details under,b/341130490)