-
Notifications
You must be signed in to change notification settings - Fork 197
TE-3.2 - Update metadata.textproto #4974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @AmrNJ, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a platform-specific deviation for Juniper devices within the test metadata. It explicitly marks the configuration of port speed on breakout ports as unsupported for Juniper, ensuring that automated tests and configurations correctly account for this hardware limitation. This prevents potential issues or misconfigurations when interacting with Juniper network equipment under these specific conditions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Pull Request Functional Test Report for #4974 / 9577e42Virtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request enables the port_speed_unsupported deviation for Juniper devices in the weighted balancing test. The change in metadata.textproto is correct. However, as noted in the review comment, the process for extending a deviation to a new platform appears incomplete. To adhere to the repository's contribution guidelines, an issue tracker link for Juniper should be added to the PortSpeedUnsupported accessor function in internal/deviations/deviations.go. This is important for tracking the deviation and its eventual removal.
feature/gribi/otg_tests/weighted_balancing_test/metadata.textproto
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 20773300636Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Juniper needs the deviation to be enabled as configuring the port-speed on a port that is on a breakout is not supported.