Skip to content

Conversation

@AmrNJ
Copy link
Contributor

@AmrNJ AmrNJ commented Jan 6, 2026

Juniper needs the deviation to be enabled as configuring the port-speed on a port that is on a breakout is not supported.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @AmrNJ, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a platform-specific deviation for Juniper devices within the test metadata. It explicitly marks the configuration of port speed on breakout ports as unsupported for Juniper, ensuring that automated tests and configurations correctly account for this hardware limitation. This prevents potential issues or misconfigurations when interacting with Juniper network equipment under these specific conditions.

Highlights

  • Juniper Platform Deviation: Enabled the "port_speed_unsupported" deviation for Juniper platforms within the "metadata.textproto" file. This change addresses the limitation where configuring port-speed on a breakout port is not supported on Juniper devices.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link

OpenConfigBot commented Jan 6, 2026

@AmrNJ AmrNJ marked this pull request as ready for review January 6, 2026 17:00
@AmrNJ AmrNJ requested a review from a team as a code owner January 6, 2026 17:00
@AmrNJ AmrNJ changed the title Update metadata.textproto TE-3.2 - Update metadata.textproto Jan 6, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables the port_speed_unsupported deviation for Juniper devices in the weighted balancing test. The change in metadata.textproto is correct. However, as noted in the review comment, the process for extending a deviation to a new platform appears incomplete. To adhere to the repository's contribution guidelines, an issue tracker link for Juniper should be added to the PortSpeedUnsupported accessor function in internal/deviations/deviations.go. This is important for tracking the deviation and its eventual removal.

@coveralls
Copy link

coveralls commented Jan 6, 2026

Pull Request Test Coverage Report for Build 20773300636

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 714 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.004%) to 10.019%

Files with Coverage Reduction New Missed Lines %
internal/deviations/deviations.go 3 0.0%
proto/metadata_go_proto/metadata.pb.go 711 0.0%
Totals Coverage Status
Change from base Build 20766201530: -0.004%
Covered Lines: 2227
Relevant Lines: 22227

💛 - Coveralls

@AmrNJ AmrNJ requested a review from a team as a code owner January 7, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants