Add README for Double GUE Decapsulation by mellowdrifter · Pull Request #5081 · openconfig/featureprofiles

mellowdrifter · 2026-02-11T17:49:50Z

No description provided.

gemini-code-assist · 2026-02-11T17:50:01Z

Summary of Changes

Hello @mellowdrifter, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new test entry into the test registry. The primary goal is to formally register a test for double GUE decapsulation, ensuring that this specific network functionality is covered and trackable within the existing test framework.

Highlights

New Test ID Added: A new test entry with ID "PF-1.24" and description "Double GUE Decapsulation" has been added to the testregistry.textproto file.

Changelog

testregistry.textproto
- Added a new 'test' block for "Double GUE Decapsulation" with ID "PF-1.24".

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

OpenConfigBot · 2026-02-11T17:50:12Z

Pull Request Functional Test Report for #5081 / `13359df`

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		PF-1.26: Double GUEv1 Decapsulation for Overlay Probing
Cisco 8000E		PF-1.26: Double GUEv1 Decapsulation for Overlay Probing
Cisco XRd		PF-1.26: Double GUEv1 Decapsulation for Overlay Probing
Juniper ncPTX		PF-1.26: Double GUEv1 Decapsulation for Overlay Probing
Nokia SR Linux		PF-1.26: Double GUEv1 Decapsulation for Overlay Probing
Openconfig Lemming		PF-1.26: Double GUEv1 Decapsulation for Overlay Probing

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		PF-1.26: Double GUEv1 Decapsulation for Overlay Probing
Cisco 8808		PF-1.26: Double GUEv1 Decapsulation for Overlay Probing
Juniper PTX10008		PF-1.26: Double GUEv1 Decapsulation for Overlay Probing
Nokia 7250 IXR-10e		PF-1.26: Double GUEv1 Decapsulation for Overlay Probing

Help

gemini-code-assist

Code Review

This pull request adds a new test entry for 'Double GUE Decapsulation' with ID 'PF-1.24' to the test registry. The change is straightforward, but I've noted that the new test entry is missing a readme field, which is important for test documentation and maintainability. Please add a link to the corresponding README file.

testregistry.textproto

coveralls · 2026-02-11T17:55:42Z

Pull Request Test Coverage Report for Build 22145898347

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on mellowdrifter-patch-1 at 10.076%

Totals
Change from base Build 22145251219:	10.1%
Covered Lines:	2300
Relevant Lines:	22826

💛 - Coveralls

sachendras · 2026-02-18T22:41:38Z

feature/policy_forwarding/otg_tests/double_gue_decap/README.md

+| Flow Type | Header Layer | Source IP | Destination IP | UDP Port | DSCP | TTL |
+| :--- | :--- | :--- | :--- | :--- | :--- | :--- |
+| **Flow Type #1 (IPv6/IPv6/IPv4)** | Outer IP | ATE-P1-IP | DECAP-DST-OUTER | 6081 | 35 | 70 |
+| | Middle IP | IPV6-MID-SRC | DECAP-DST-INNER | 6081 | 32 | 60 |


As per https://datatracker.ietf.org/doc/html/draft-ietf-intarea-gue-09, the default port is UDP:6080. We should have all our tests using 6080 unless there is a test which is proving that the NOS allows for ports other than 6080 too. Currently NOSs lacks support for ports other than 6080. If more FNTs request tests of 6081, lot of our FNTs will fail rather than just one which is expected.

sachendras · 2026-02-19T16:25:09Z

I have started a document offline. Lets close on that before we move forward with the Pull

nupkanoi · 2026-02-26T23:33:28Z

feature/policy_forwarding/otg_tests/double_gue_decap/README.md

+* Perform a Longest Prefix Match (LPM) lookup on the inner IP header and forward the packet towards the destination.
+* Ensure the packet arrives at the destination as `[Inner_IP_header][PAYLOAD]`.
+* Support these operations potentially via sequential VRF lookups or a single pipeline operation if supported by the vendor.
+* Performance caveats are acceptable as this is for probing traffic.


Remove this statement, we don't want to give out the details on how Google is using this feature.

sachendras · 2026-03-09T18:10:57Z

feature/policy_forwarding/otg_tests/double_gue_decap/README.md

+* Decap Aggregates: Configure DUT:Port3 with an aggregate IPv4 /28 and IPv6 /60 block address.
+* Soft-Loop: Enable software loopback on DUT Port 3.
+* Forwarding Rules:
+** Configure dual decap policies on the DUT to facilitate the decapsulation of Header 1 and Header 2 (UDP 6080). The decap policies for Header 1 (IPv6) and Header 2 (IPv4 and IPv6) must target specified aggregates: for Header 2, utilize the IPv4 /28 and IPv6 /60 blocks assigned to DUT Port 3; for Header 1, use a /60 subnet of the destination address.


seems the markdown needs to be fixed

sachendras · 2026-03-09T18:58:01Z

feature/policy_forwarding/otg_tests/double_gue_decap/README.md

+| | Middle IP | IPV6-MID-SRC | DECAP-DST-INNER | 6080 | 32 | 60 |
+| | Inner IP | IPV6-SRC-HOST | IPV6-DST-HOST | N/A | 20 | 50 |
+
+### Traffic Generation:


Markdown needs correction

sachendras

I have highlighted the sections that needs Markdown update. Please review your changes in the "Preview" Section.

sachendras · 2026-03-09T19:01:35Z

/gcbrun

feature/policy_forwarding/otg_tests/double_gue_decap/README.md

feature/policy_forwarding/otg_tests/double_gue_decap/metadata.textproto

ram-mac · 2026-03-20T14:24:53Z

feature/policy_forwarding/otg_tests/double_gue_decap/README.md

+* Decap Aggregates: Configure DUT:Port3 with an aggregate IPv4 /28 and IPv6 /60 block address.
+* Soft-Loop: Enable software loopback on DUT Port 3.
+* Forwarding Rules:
+** Configure dual decap policies on the DUT to facilitate the decapsulation of Header 1 and Header 2 (UDP 6080). The decap policies for Header 1 (IPv6) and Header 2 (IPv4 and IPv6) must target specified aggregates: for Header 2, utilize the IPv4 /28 and IPv6 /60 blocks assigned to DUT Port 3; for Header 1, use a /60 subnet of the destination address.


@mellowdrifter - I think the policy can be broken down into points for easy understanding. Seems too dense

Signed-off-by: Darren O’Connor <mellowd@google.com>

mellowdrifter · 2026-03-26T15:44:48Z

Closing in favor of the new clean PR.

mellowdrifter requested a review from a team as a code owner February 11, 2026 17:49

gemini-code-assist bot reviewed Feb 11, 2026

View reviewed changes

testregistry.textproto Show resolved Hide resolved

mellowdrifter changed the title ~~Add ID for Double GUE Decapsulation~~ Add README for Double GUE Decapsulation Feb 11, 2026

mellowdrifter force-pushed the mellowdrifter-patch-1 branch from fdd4bda to c25cb5b Compare February 18, 2026 15:25

sachendras reviewed Feb 18, 2026

View reviewed changes

nupkanoi reviewed Feb 26, 2026

View reviewed changes

sachendras reviewed Mar 9, 2026

View reviewed changes

sachendras self-requested a review March 9, 2026 19:00

sachendras approved these changes Mar 9, 2026

View reviewed changes

nupkanoi reviewed Mar 17, 2026

View reviewed changes

feature/policy_forwarding/otg_tests/double_gue_decap/README.md Outdated Show resolved Hide resolved

nupkanoi reviewed Mar 17, 2026

View reviewed changes

feature/policy_forwarding/otg_tests/double_gue_decap/README.md Outdated Show resolved Hide resolved

nupkanoi reviewed Mar 17, 2026

View reviewed changes

feature/policy_forwarding/otg_tests/double_gue_decap/README.md Outdated Show resolved Hide resolved

nupkanoi reviewed Mar 17, 2026

View reviewed changes

feature/policy_forwarding/otg_tests/double_gue_decap/README.md Show resolved Hide resolved

nupkanoi reviewed Mar 17, 2026

View reviewed changes

feature/policy_forwarding/otg_tests/double_gue_decap/README.md Outdated Show resolved Hide resolved

ksgireesha requested a review from ram-mac March 20, 2026 14:09

ram-mac requested changes Mar 20, 2026

View reviewed changes

mellowdrifter force-pushed the mellowdrifter-patch-1 branch 2 times, most recently from 59c8630 to 13359df Compare March 26, 2026 12:40

feat: add Double GUE Decapsulation test (PF-1.26)

b3cd1da

Signed-off-by: Darren O’Connor <mellowd@google.com>

mellowdrifter force-pushed the mellowdrifter-patch-1 branch from 13359df to b3cd1da Compare March 26, 2026 12:55

mellowdrifter requested review from a team as code owners March 26, 2026 12:55

mellowdrifter closed this Mar 26, 2026

Conversation

mellowdrifter commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Feb 11, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

OpenConfigBot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Functional Test Report for #5081 / 13359df

Virtual Devices

Hardware Devices

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

coveralls commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 22145898347

Details

💛 - Coveralls

Uh oh!

sachendras Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

sachendras commented Feb 19, 2026

Uh oh!

nupkanoi Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

sachendras Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

sachendras Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

sachendras left a comment

Choose a reason for hiding this comment

Uh oh!

sachendras commented Mar 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ram-mac Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

mellowdrifter commented Mar 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mellowdrifter commented Feb 11, 2026 •

edited

Loading

OpenConfigBot commented Feb 11, 2026 •

edited

Loading

Pull Request Functional Test Report for #5081 / `13359df`

coveralls commented Feb 11, 2026 •

edited

Loading