RT-7.9 Adding deviation

[cprabha]

Hi,

I have added existing deviations to RT-7.9 test. Also moved routing policy config prior to BGP configuration.

[gemini-code-assist]

Summary of Changes

Hello @cprabha, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the multipath_bgp_ecmp_protocol_nexthop test by incorporating necessary platform-specific deviations for Juniper devices and adjusting the order of configuration steps. These changes ensure the test accurately reflects the expected behavior and configuration dependencies in the testing environment.

Highlights

• Test Deviations: Added specific platform deviations for Juniper devices, including isis_level_enabled, interface_ref_interface_id_format, and bgp_max_multipath_paths_unsupported, to the metadata.textproto file for the multipath_bgp_ecmp_protocol_nexthop test.
• Configuration Order: Reordered the test setup in multipath_bgp_ecmp_protocol_nexthop_test.go to ensure that routing policy configuration (configureRoutePolicy) is applied before the main DUT configuration (configureDUT).

Changelog

• feature/bgp/policybase/otg_tests/multipath_bgp_ecmp_protocol_nexthop/metadata.textproto
  • Added a new platform_exceptions block for Juniper, specifying isis_level_enabled, interface_ref_interface_id_format, and bgp_max_multipath_paths_unsupported deviations.
• feature/bgp/policybase/otg_tests/multipath_bgp_ecmp_protocol_nexthop/multipath_bgp_ecmp_protocol_nexthop_test.go
  • Moved the configureRoutePolicy function call to execute before configureDUT within the TestMultipathBGPEcmpProtocolNexthop function.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5095 / be199fd

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-7.9: BGP ECMP for iBGP with IS-IS protocol nexthop
Cisco 8000E		RT-7.9: BGP ECMP for iBGP with IS-IS protocol nexthop
Cisco XRd		RT-7.9: BGP ECMP for iBGP with IS-IS protocol nexthop
Juniper ncPTX		RT-7.9: BGP ECMP for iBGP with IS-IS protocol nexthop
Nokia SR Linux		RT-7.9: BGP ECMP for iBGP with IS-IS protocol nexthop
Openconfig Lemming		RT-7.9: BGP ECMP for iBGP with IS-IS protocol nexthop

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-7.9: BGP ECMP for iBGP with IS-IS protocol nexthop
Cisco 8808		RT-7.9: BGP ECMP for iBGP with IS-IS protocol nexthop
Juniper PTX10008		RT-7.9: BGP ECMP for iBGP with IS-IS protocol nexthop
Nokia 7250 IXR-10e		RT-7.9: BGP ECMP for iBGP with IS-IS protocol nexthop

Help

[gemini-code-assist]

Code Review

This pull request correctly adds platform-specific deviations for Juniper devices to the RT-7.9 test. It also fixes a bug in the test setup by ensuring the routing policy is configured before it is referenced by the BGP configuration. The changes are well-implemented and improve the test. I have no further suggestions.

[coveralls]

Pull Request Test Coverage Report for Build 22118600501

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 10.091%

---

Totals
Change from base Build 22113180336:	0.0%
Covered Lines:	2300
Relevant Lines:	22792

---

💛 - Coveralls