Skip to content

move mtu test to proper folder#5239

Open
dplore wants to merge 4 commits intomainfrom
dplore/movemtu
Open

move mtu test to proper folder#5239
dplore wants to merge 4 commits intomainfrom
dplore/movemtu

Conversation

@dplore
Copy link
Member

@dplore dplore commented Mar 19, 2026

MTU test folder should roughly follow the openconfig schema:

/interfaces/interface/config/mtu

@dplore dplore requested review from a team as code owners March 19, 2026 22:54
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the directory structure for MTU-related tests by relocating them to a more semantically appropriate path. The change ensures that the test folder hierarchy mirrors the OpenConfig schema for interface MTU, enhancing discoverability and maintainability for future development and testing efforts without altering any test logic.

Highlights

  • File Restructuring: Moved all MTU-related test files and their associated metadata to a new directory path, feature/interface/mtu/..., to align with the OpenConfig schema for interface MTU configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link

OpenConfigBot commented Mar 19, 2026

Pull Request Functional Test Report for #5239 / f522ace

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
status
status
MTU-1.3: Large IP Packet Transmission
MTU-1.5: Path MTU handing
MTU-1.4: Large IP Packet through GRE/GUE tunnel Transmission
d2386c2c Log
Cisco 8000E status
status
status
MTU-1.3: Large IP Packet Transmission
MTU-1.5: Path MTU handing
MTU-1.4: Large IP Packet through GRE/GUE tunnel Transmission
e52e0a5d Log
Cisco XRd status
status
status
MTU-1.3: Large IP Packet Transmission
MTU-1.5: Path MTU handing
MTU-1.4: Large IP Packet through GRE/GUE tunnel Transmission
ab72fc8e Log
Juniper ncPTX status
status
status
MTU-1.3: Large IP Packet Transmission
MTU-1.5: Path MTU handing
MTU-1.4: Large IP Packet through GRE/GUE tunnel Transmission
3f78c7df Log
Nokia SR Linux status
status
status
MTU-1.3: Large IP Packet Transmission
MTU-1.5: Path MTU handing
MTU-1.4: Large IP Packet through GRE/GUE tunnel Transmission
17c22514 Log
Openconfig Lemming status
status
status
MTU-1.3: Large IP Packet Transmission
MTU-1.5: Path MTU handing
MTU-1.4: Large IP Packet through GRE/GUE tunnel Transmission
a0a1bb50 Log

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
status
status
MTU-1.3: Large IP Packet Transmission
MTU-1.5: Path MTU handing
MTU-1.4: Large IP Packet through GRE/GUE tunnel Transmission
Cisco 8808 status
status
status
MTU-1.3: Large IP Packet Transmission
MTU-1.5: Path MTU handing
MTU-1.4: Large IP Packet through GRE/GUE tunnel Transmission
Juniper PTX10008 status
status
status
MTU-1.3: Large IP Packet Transmission
MTU-1.5: Path MTU handing
MTU-1.4: Large IP Packet through GRE/GUE tunnel Transmission
Nokia 7250 IXR-10e status
status
status
MTU-1.3: Large IP Packet Transmission
MTU-1.5: Path MTU handing
MTU-1.4: Large IP Packet through GRE/GUE tunnel Transmission

Help

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces or updates test cases, READMEs, and metadata files related to MTU (Maximum Transmission Unit) handling within OTG (Open Traffic Generator) tests. Specifically, it addresses scenarios involving large IP packet transmission, including those with GRE/GUE tunnels, and PMTU (Path MTU) handling. No specific code changes or review comments were provided for detailed analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants