adding new topology and config files to support ncPTX-BX version

[sudhirakondi]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the network emulation capabilities by integrating support for the Juniper ncPTX-BX platform. It provides a comprehensive set of new topology and configuration files, allowing users to deploy and test various network scenarios involving single or multiple ncPTX-BX devices, as well as interactions with ATE (Automated Test Equipment) nodes. This enhancement broadens the scope of testable network designs and improves the flexibility of the KNE environment for Juniper devices.

Highlights

• New Topology Files Added: Introduced several new topology definition files (.textproto) to support various Juniper ncPTX-BX network configurations, including single DUT, DUT-ATE, 2-DUT, and 3-DUT setups.
• New Configuration Files Added: Added multiple Juniper configuration files (.cfg) tailored for the ncPTX-BX platform, providing base configurations and specific configurations for individual DUTs within multi-device topologies.
• ncPTX-BX Version Support: The new files explicitly enable support for the ncPTX-BX version of Juniper devices within the KNE environment, including specific environment variables for CPTX_COSIM and JUNOS_EVOLVED_CONTAINER.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5241 / b57542e

No tests identified for validation.

Help

[gemini-code-assist]

Code Review

This pull request adds a new set of topology and configuration files for the ncptx-bx platform. The changes introduce several new directories and files. My review focuses on adherence to the repository's style guide, particularly concerning directory naming conventions and network address assignments. I've found several violations:

• The new directory ncptx-bx uses a hyphen, which is against the naming convention.
• Several configuration files use prohibited or discouraged IP addresses (e.g., 1.1.1.1, 10.x.x.x ranges, and non-documentation IPv6 addresses).
• There is a critical IP address conflict where two devices are assigned the same IP.
• One configuration file has inconsistent formatting.
  I've provided specific suggestions to align the configurations with the project's standards.