Adding test for RT-1.67

[Steubert]

README: https://github.com/openconfig/featureprofiles/blob/main/feature/staticroute/otg_tests/static_route_with_vlan_interface/README.md
Passed Logs: https://partnerissuetracker.corp.google.com/issues/415458482#comment185

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a comprehensive test for validating static route functionality over a VLAN Switched Virtual Interface (SVI) within the featureprofiles framework. The test covers both direct Layer 3 forwarding and forwarding via recursive static routes for IPv4 and IPv6 traffic. To facilitate this, the PR enhances existing configuration utilities and adds new helper functions for VLAN, SVI, and static route configurations, ensuring robust and OpenConfig-compliant test setups.

Highlights

• New Test Case: Introduced static_route_with_vlan_interface_test.go to validate IPv4/IPv6 forwarding over VLAN SVI and recursive static routes.
• Static Route Configuration Enhancement: Updated internal/cfgplugins/staticroute.go to support interface-based next-hops for static routes, crucial for resolution routes.
• VLAN and SVI Configuration Helpers: Added ConfigureAccessVlan and ConfigureSVI functions in internal/cfgplugins/interface.go to streamline VLAN and Switched Virtual Interface (SVI) configurations.
• OpenConfig VLAN Model Adoption: Modified ConfigureVlan in internal/cfgplugins/interface.go to utilize the OpenConfig global VLAN model for configuration.
• Metadata Update: Included static_protocol_name: "STATIC" in metadata.textproto to align with static route protocol naming conventions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5243 / 05964dd

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-1.67: IPv4 and IPv6 Static Route using Vlan Interface
Cisco 8000E		RT-1.67: IPv4 and IPv6 Static Route using Vlan Interface
Cisco XRd		RT-1.67: IPv4 and IPv6 Static Route using Vlan Interface
Juniper ncPTX		RT-1.67: IPv4 and IPv6 Static Route using Vlan Interface
Nokia SR Linux		RT-1.67: IPv4 and IPv6 Static Route using Vlan Interface
Openconfig Lemming		RT-1.67: IPv4 and IPv6 Static Route using Vlan Interface

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-1.67: IPv4 and IPv6 Static Route using Vlan Interface
Cisco 8808		RT-1.67: IPv4 and IPv6 Static Route using Vlan Interface
Juniper PTX10008		RT-1.67: IPv4 and IPv6 Static Route using Vlan Interface
Nokia 7250 IXR-10e		RT-1.67: IPv4 and IPv6 Static Route using Vlan Interface

Help

[gemini-code-assist]

Code Review

This pull request introduces a new test for static routes over a VLAN interface (RT-1.67), along with supporting helper functions in cfgplugins for VLAN, SVI, and static route configurations. The changes are well-structured and the new test covers the intended functionality. My review focuses on improving the correctness of test validations and enhancing the reusability and robustness of the new helper functions. I've identified a few logical issues in traffic and counter validation within the test, and suggested improvements for consistency with device deviations in the configuration helpers. All comments align with repository rules, with one comment explicitly referencing the preference for t.Errorf over t.Fatalf in tests.