Skip to content

RT-5.7 Fix #5263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
suredhar wants to merge 1 commit into from
+0 −1
Closed

RT-5.7 Fix #5263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion feature/interface/aggregate/otg_tests/aggregate_all_not_viable_test/metadata.textproto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ platform_exceptions: {
wecmp_auto_unsupported: true
isis_loopback_required: true
weighted_ecmp_fixed_packet_verification: true
interface_ref_interface_id_format: true
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

While removing interface_ref_interface_id_format: true is a correct step for Cisco devices, this pull request appears to be incomplete. The PR description details other necessary changes in aggregate_all_not_forwarding_viable_test.go to fully resolve the issue, specifically the configuration of a loopback interface for ISIS as required by the isis_loopback_required: true deviation on line 29. This logic seems to be missing from the Go test file. Without these accompanying code changes, the test is likely to remain broken.

}
}

Expand Down
Loading