CISCO : MGT-1 Fix

[suredhar]

Summary
This change fixes IPv6 traffic generation in the Management HA OTG test by using ICMPv6 instead of ICMPv4 on an IPv6 packet stack.

Issue
The IPv6 flow builder in feature/system/management/otg_tests/management_ha_test/management_ha_test.go was creating:

Ethernet
IPv6
ICMP (v4)
This is a protocol mismatch. For an IPv6 flow, the correct L4 payload is ICMPv6.

Root cause
The flow used ICMPv4 APIs:

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a protocol mismatch in the Management HA OTG test suite. By correcting the L4 payload type for IPv6 flows, the change ensures that traffic generation aligns with standard networking protocols, improving the reliability of the test environment.

Highlights

• Protocol Correction: Updated the IPv6 flow builder to use ICMPv6 instead of ICMPv4 to resolve a protocol mismatch.
• API Update: Switched to the correct gosnappi ICMPv6 methods for IPv6 traffic generation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5279 / 0b52bed

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		MGT-1: Management HA solution test
Cisco 8000E		MGT-1: Management HA solution test
Cisco XRd		MGT-1: Management HA solution test
Juniper ncPTX		MGT-1: Management HA solution test
Nokia SR Linux		MGT-1: Management HA solution test
Openconfig Lemming		MGT-1: Management HA solution test

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		MGT-1: Management HA solution test
Cisco 8808		MGT-1: Management HA solution test
Juniper PTX10008		MGT-1: Management HA solution test
Nokia 7250 IXR-10e		MGT-1: Management HA solution test

Help

[gemini-code-assist]

Code Review

This pull request updates the createFlowV6 function in the management HA test to correctly use ICMPv6 methods (Icmpv6 and NewFlowIcmpv6Echo) for IPv6 traffic flows, replacing the previous ICMPv4-specific calls. I have no feedback to provide as there were no review comments.

[MarcCharlebois]

duplicate of #5185 ?

@dplore - Any chance to get an improvement on the Gemini Review bot to compare existing PRs to prevent duplications?

[suredhar]

duplicate of #5185