Skip to content

Fix volume options and error code in CNTR-1 test #5288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
goabhinav wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix volume options and error code in CNTR-1 test #5288

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1fb96f
Fix volume options and error code in CNTR-1 test
goabhinav Apr 1, 2026
caf2087
Fix want options in TestVolumes
goabhinav Apr 1, 2026
d1a907c
Fix error message in TestVolumes
goabhinav Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions feature/container/containerz/tests/container_lifecycle/containerz_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,13 +490,12 @@ func TestVolumes(t *testing.T) {
}
// Allow time for removal to settle.
time.Sleep(5 * time.Second)

mountOpts := map[string]string{
volOpts := map[string]string{
"type": "none",
"options": "bind",
"mountpoint": "/some-path",
"mountpoint": "/tmp",
}

createdVolumeName, err := cli.CreateVolume(ctx, volumeName, "local", nil, mountOpts)
createdVolumeName, err := cli.CreateVolume(ctx, volumeName, "local", nil, volOpts)
if err != nil {
t.Fatalf("CreateVolume(%q, \"local\", nil, nil) failed: %v", volumeName, err)
}
Expand Down Expand Up @@ -857,7 +856,7 @@ func TestPlugins(t *testing.T) {
} else {
t.Logf("Got expected error when starting with non-existent image %q: %v", pluginName, err)
s, ok := status.FromError(err)
if !ok || (s.Code() != codes.Unknown && s.Code() != codes.FailedPrecondition) {
if !ok || (s.Code() != codes.Unknown && s.Code() != codes.NotFound) {
t.Errorf("Expected gRPC status code Unknown or NotFound for non-existent image, got: %v (status code: %s)", err, s.Code())
}
}
Expand Down
Loading