RT-1.1: Enabling TCP FIN-Delay for Cease notification#5290
RT-1.1: Enabling TCP FIN-Delay for Cease notification#5290trathod1 wants to merge 3 commits intoopenconfig:mainfrom
Conversation
OTG fix to add FIN delay is made available in ixia-c version V1.51.0.
Following changes are done -
1. Updating script to use "SetFinDelay()" function.
2. Updating go.mod/go.sum to update gosnappi package version to use v1.51.0
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a necessary delay in TCP FIN packets during BGP cease notifications to ensure stability in specific network emulation environments. Additionally, it performs a routine update of project dependencies to maintain compatibility and leverage the latest features and fixes provided by the updated packages. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5290 / b286cafVirtual Devices
Hardware Devices
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the gosnappi dependency to version 1.51.0 and introduces a SetFinDelay configuration in the BGP cease action for OTG tests. Feedback was provided regarding the inclusion of unrelated toolchain and dependency updates in go.mod, which should be reverted to maintain a clean PR scope. Additionally, the magic number 500 used for the FIN delay should be replaced with a named constant or documented with a comment according to repository rules.
| module github.com/openconfig/featureprofiles | ||
|
|
||
| go 1.24.7 | ||
| go 1.25.0 |
There was a problem hiding this comment.
The Go version is being updated to 1.25.0, and numerous other dependencies (e.g., otel, grpc, crypto, oauth2) are being updated alongside gosnappi. These changes are not mentioned in the PR description and appear unrelated to the primary objective of enabling TCP FIN-Delay. Bundling unrelated dependency and toolchain updates increases the risk of regressions and can break compatibility for other contributors or CI environments. It is recommended to revert these unrelated changes and only update the gosnappi version as intended.
feature/bgp/otg_tests/base_bgp_session_parameters/base_bgp_session_parameters_test.go
Outdated
Show resolved
Hide resolved
2 participants
OTG fix to add FIN delay is made available in ixia-c version V1.51.0 - issues/46
Following changes are done -
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."