CNTR-3.8: Set restart policy to always in cold reboot persistence test

[prathapcv]

Fixes #5268

TestContainerPersistenceAfterColdReboot started container with default restart policy (none), so container did not restart after cold reboot.
Added client.WithRestartPolicy("always") in startOpts to align behavior with expected post-reboot RUNNING state.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where a container failed to restart following a cold reboot during testing. By explicitly setting the restart policy to 'always', the test now correctly verifies that the container returns to a running state as expected after the system reboots.

Highlights

• Test Configuration Update: Updated the container start options in the cold reboot persistence test to include a restart policy of 'always'.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5296 / 91c49e2

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		CNTR-3: Container Supervisor Failover
Cisco 8000E		CNTR-3: Container Supervisor Failover
Cisco XRd		CNTR-3: Container Supervisor Failover
Juniper ncPTX		CNTR-3: Container Supervisor Failover
Nokia SR Linux		CNTR-3: Container Supervisor Failover
Openconfig Lemming		CNTR-3: Container Supervisor Failover

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		CNTR-3: Container Supervisor Failover
Cisco 8808		CNTR-3: Container Supervisor Failover
Juniper PTX10008		CNTR-3: Container Supervisor Failover
Nokia 7250 IXR-10e		CNTR-3: Container Supervisor Failover

Help

[gemini-code-assist]

Code Review

This pull request updates the TestContainerPersistenceAfterColdReboot test in failover_test.go by adding a restart policy of "always" to the container start options. This ensures the container is configured to restart automatically during the failover test scenario. There were no review comments provided, and I have no feedback to provide.